Exception Handling Fix for Dynamically Compiled Code#654
Closed
lmjantsch wants to merge 3 commits into
Closed
Conversation
Author
|
@JadenFiotto-Kaufman If you have another idea in mind to fix this I can give it a shot. |
Member
|
@lmjantsch can you point your PR towards the dev branch. That's the default place for merging first, thanks! |
Author
|
I created a new pull request (#658) that implements the changes on the dev branch and points to it. If you would like contributions to be pointed to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
Exceptions in code compiled by
convert()(which injects operation wrapping into forward methods using generic <nnsight> filename) crashedExceptionWrapper._collect_frames()with aKeyError. The exception handler only knew how to mapTracer.Infoframes, notconvert()frames.The Solution
Three files were modified:
1.
globals.pyAdded a metadata registry:
2.
inject.pyModified
convert()to register metadata before compiling:3.
util.pyUpdated
ExceptionWrapper._collect_frames()to check both mappings:Result
convert()compiled code no longer crashTracerandconvert()frames are handled