Fix stop callback actions in forced unwind - #61
Merged
nbdd0121 merged 1 commit intoJul 20, 2026
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
The stop function always gets the
END_OF_STACKunwind action and never getsCLEANUP_PHASE. Additionally, this renders theframe.is_none()block justbelow it dead code.
libgcc and libunwind both pass
_UA_FORCE_UNWIND | _UA_CLEANUP_PHASEon every frame and add
_UA_END_OF_STACKonly at the actual end.Fix:
This fix replicates libgcc and libunwind behaviour for the stop callback.