Use sccache in CI - #746
Closed
nazar-pc wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to speed up Rust CI by enabling sccache as a rustc wrapper, and it also updates the pinned Rust nightly to pick up latest solver performance improvements.
Changes:
- Enable
sccachein CI viaRUSTC_WRAPPER=sccacheand add an install step anchored for reuse. - Refactor
taiki-e/install-actionusage to a single pinned anchor (*install-action-version) for consistency. - Bump the pinned Rust toolchain from
nightly-2026-07-22tonightly-2026-07-31.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust-toolchain.toml | Updates the pinned nightly toolchain date. |
| .github/workflows/rust.yml | Enables sccache globally and adds reusable installation wiring in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/workflows/rust.yml:132
- The
Use sccachestep relies on bash-style env var expansion and redirection (>> $GITHUB_ENV) but doesn’t specifyshell: bash. On Windows runners the default shell is PowerShell, so$GITHUB_ENVwon’t resolve and this step can fail / not setRUSTC_WRAPPERfor subsequent steps. This file also consistently quotes$GITHUB_ENVelsewhere (e.g.rust.yml:109).
- &use-sccache-step
name: Use sccache
run: |
echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
Owner
Author
|
Had to roll back nightly upgrade due to mozilla/sccache#2787 / rust-lang/cargo#17258 |
Owner
Author
|
For our purposes it is actually slower instead of faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help making CI faster