Repository navigation
Cornell CS 4789 lecture: minor tweaks - #545
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…all text edits Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngineering Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e55fe95d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $A h$ is a single number, so write $c = A h$. The adapter adds $c$ times the vector $B$ to the logits: | ||
|
|
||
| <!-- step --> | ||
| $$z = W h + c \, B$$ |
There was a problem hiding this comment.
Reveal the new LoRA derivation one step at a time
During presentation, this new slide displays the entire derivation and its conclusion immediately because it contains no <!-- step --> markers. This violates the math-derivation unroll requirement in teach/AGENTS.md, which requires revealing each manipulation separately so the audience can follow the argument. Add step markers before the substitution of c, the chain-rule calculation, and the final optimizer-update interpretation.
AGENTS.md reference: teach/AGENTS.md:L29-L29
Useful? React with 👍 / 👎.
Summary
Final tweaks to the Cornell CS 4789 guest lecture deck (
teach/Cornell-CS4789-2026/) before the 18 Nov talk.Changes
talk.css.content-tightCSS class so the two-line-title slide on Tinker's 8-token approximation fits.Checks
teach/scripts/check_slide_overflow.pyis clean except "Comparing logits/gradients in Tinker", where the figure caption sits close to the footnote link. That was already flagged onmain.The first commit on this branch is empty (it opened the draft), so squash-merge.
🤖 Generated with Claude Code