Skip to content

GetSectionHeader: bound the section-name read loop (matches GetSymbol fix from #32) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nurdymuny wants to merge 5 commits into
base: main
Choose a base branch
from
Open

GetSectionHeader: bound the section-name read loop (matches GetSymbol fix from #32) #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a719b1
Integration: Begin post v7.0.1 development cycle
jphickey May 13, 2026
b331ef2
Merge pull request #159 from jphickey/ic-devcycle-v7.0.1-start
jphickey May 13, 2026
46709ae
Part cFS/workflows#129, Use Updated Static Analysis Workflow
arielswalker May 13, 2026
a8710d2
Merge pull request #160 from arielswalker/part-cfs/workflows#129-use-…
arielswalker May 14, 2026
cb7d37a
GetSectionHeader: bound the section-name read loop
nurdymuny Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: Static Analysis

# Run on all push and pull requests
on:
push:
branches:
Expand All @@ -17,4 +16,4 @@ jobs:

static-analysis:
name: Run cppcheck
uses: nasa/cFS/.github/workflows/static-analysis.yml@main
uses: nasa/cFS/.github/workflows/static-analysis-reusable.yml@dev
3 changes: 2 additions & 1 deletion elf2cfetbl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1777,10 +1777,11 @@ int32 GetSectionHeader(int32 SectionIndex, union Elf_Shdr *SectionHeader)
printf(" sh_name = 0x%08x - ", get_sh_name(SectionHeader));
fseek(SrcFileDesc, SeekOffset, SEEK_SET);

while ((VerboseStr[i] = fgetc(SrcFileDesc)) != '\0')
while ((i < sizeof(VerboseStr)) && ((VerboseStr[i] = fgetc(SrcFileDesc)) != '\0'))
{
i++;
}
VerboseStr[i % sizeof(VerboseStr)] = '\0'; /* nul-terminate; see the GetSymbol() loop for the same fix shape */
if (Verbose)
printf("%s\n", VerboseStr);

Expand Down
4 changes: 2 additions & 2 deletions elf2cfetbl_version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
/*
* Development Build Macro Definitions
*/
#define ELF2CFETBL_BUILD_NUMBER 0 /*!< @brief Number of commits since baseline */
#define ELF2CFETBL_BUILD_NUMBER 1 /*!< @brief Number of commits since baseline */
#define ELF2CFETBL_BUILD_BASELINE "v7.0.1" /*!< @brief Development Build: git tag that is the base for the current */
#define ELF2CFETBL_BUILD_DEV_CYCLE "v7.0.1" /**< @brief Development: Release name for current development cycle */
#define ELF2CFETBL_BUILD_CODENAME "Draco" /**< @brief: Development: Code name for the current build */
Expand All @@ -52,7 +52,7 @@
* Values 1-254 are reserved for mission use to denote patches/customizations as needed. NOTE: Reserving 0 and 0xFF for
* cFS open-source development use (pending resolution of nasa/cFS#440)
*/
#define ELF2CFETBL_MISSION_REV 0x0
#define ELF2CFETBL_MISSION_REV 0xFF

/*
* Tools to construct version string
Expand Down
Loading