Fix #494, PSP RTEMS typo fix - #495
Merged
Merged
Conversation
Contributor
Author
|
Static analysis/cppcheck failing is apparently a bug. Downloaded artifacts: These 4 are the same errors reported here. |
Cameron-Sykes
self-requested a review
July 23, 2026 14:10
Cameron-Sykes
approved these changes
Jul 23, 2026
Cameron-Sykes
left a comment
There was a problem hiding this comment.
I hereby declare this PR to be completed to a satisfactory level. It shall be merged into dev upon the clearing of the pipeline issues by an outside authority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
This is a typo fix (for Fix #494). The error appears when compiling a fresh copy of coreFlight using the OS Ubuntu 26.04 (Resolute Raccoon), the newest release of Ubuntu. This compiling error did not appear in previous versions of Ubuntu like 22.04 (Jammy Jellyfish) or 24.04 (Noble Numbat). It also doesn't show up in Red Hat.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Before, compiling a fresh copy of coreFlight while using Ubuntu Resolute Racoon, the following error would happen:
Code snips
https://github.com/nasa/PSP/blob/ce9126a61dd9233d6b33b92b9e65fca9989e7d5c/unit-test-coverage/ut-stubs/override_inc/rtems/score/todimpl.h
There is a typo here. The D and O in TODIMPL look so close.
After changing the typo, the code compiles correctly on Resolute Raccoon.