Fix #90, standardize patterns across all internal functions - #510
Open
jphickey wants to merge 2 commits into
Open
Fix #90, standardize patterns across all internal functions#510jphickey wants to merge 2 commits into
jphickey wants to merge 2 commits into
Conversation
Updates all code to follow the same pattern: - channel numbers are used only in CMD/TLM/Tables (external) - channel number is converted to a pointer, with error checking - only channel pointer is used therein This change removes all ambiguity about whether the passed-in value is range checked or not. Repeated conversions between channel number and channel pointer are removed, and code is much simpler as a result. Also fixes nasa#288
jphickey
force-pushed
the
fix-90-chan-access-patterns
branch
from
August 6, 2026 11:59
d6e5adf to
d82f543
Compare
chillfig
self-requested a review
August 6, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Updates all code to follow the same pattern:
This change removes all ambiguity about whether the passed-in value is range checked or not. Repeated conversions between channel number and channel pointer are removed, and code is much simpler as a result.
Fixes #90
Fixes #288
Testing performed
Execute file transfers to verify operation
System(s) tested on
Linux
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.