-
Notifications
You must be signed in to change notification settings - Fork 151
feat(notificationChannels): add Plivo SMS and voice channel config form #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sarveshpatil-plivo
wants to merge
1
commit into
n9e:main
Choose a base branch
from
sarveshpatil-plivo:plivo-notification-channels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import { useTranslation } from 'react-i18next'; | ||
| import { NS } from '../../constants'; | ||
| import { Form, Input, InputNumber, Select, Space, Tooltip } from 'antd'; | ||
| import React from 'react'; | ||
| import { QuestionCircleOutlined } from '@ant-design/icons'; | ||
|
|
||
| export default function Plivo() { | ||
| const { t } = useTranslation(NS); | ||
| const names = ['request_config', 'plivo_request_config']; | ||
| const request_type = Form.useWatch('request_type'); | ||
| const ident = Form.useWatch('ident'); | ||
| const isPlivo = request_type === 'plivo'; | ||
| const isVoice = ident === 'plivo-voice'; | ||
|
|
||
| return ( | ||
| <div | ||
| style={{ | ||
| display: isPlivo ? 'block' : 'none', | ||
| }} | ||
| > | ||
| <Form.Item label={t('plivo_request_config.auth_id')} name={[...names, 'auth_id']} rules={[{ required: isPlivo }]}> | ||
| <Input /> | ||
| </Form.Item> | ||
| <Form.Item label={t('plivo_request_config.auth_token')} name={[...names, 'auth_token']} rules={[{ required: isPlivo }]}> | ||
| <Input.Password /> | ||
| </Form.Item> | ||
| <Form.Item | ||
| label={ | ||
| <Space size={4}> | ||
| {t('plivo_request_config.src_number')} | ||
| <Tooltip className='n9e-ant-from-item-tooltip' overlayClassName='ant-tooltip-max-width-600' title={t('plivo_request_config.src_number_tip')}> | ||
| <QuestionCircleOutlined /> | ||
| </Tooltip> | ||
| </Space> | ||
| } | ||
| name={[...names, 'src_number']} | ||
| rules={[{ required: isPlivo }]} | ||
| > | ||
| <Input /> | ||
| </Form.Item> | ||
| {isVoice && ( | ||
| <Form.Item | ||
| label={ | ||
| <Space size={4}> | ||
| {t('plivo_request_config.answer_url')} | ||
| <Tooltip className='n9e-ant-from-item-tooltip' overlayClassName='ant-tooltip-max-width-600' title={t('plivo_request_config.answer_url_tip')}> | ||
| <QuestionCircleOutlined /> | ||
| </Tooltip> | ||
| </Space> | ||
| } | ||
| name={[...names, 'answer_url']} | ||
| rules={[{ required: isVoice }]} | ||
| > | ||
| <Input /> | ||
| </Form.Item> | ||
| )} | ||
| {isVoice && ( | ||
| <Form.Item | ||
| label={ | ||
| <Space size={4}> | ||
| {t('plivo_request_config.answer_method')} | ||
| <Tooltip className='n9e-ant-from-item-tooltip' overlayClassName='ant-tooltip-max-width-600' title={t('plivo_request_config.answer_method_tip')}> | ||
| <QuestionCircleOutlined /> | ||
| </Tooltip> | ||
| </Space> | ||
| } | ||
| name={[...names, 'answer_method']} | ||
| > | ||
| <Select | ||
| options={[ | ||
| { label: 'POST', value: 'POST' }, | ||
| { label: 'GET', value: 'GET' }, | ||
| ]} | ||
| /> | ||
| </Form.Item> | ||
| )} | ||
| <Form.Item label={t('plivo_request_config.proxy')} tooltip={t('plivo_request_config.proxy_tip')} name={[...names, 'proxy']}> | ||
| <Input /> | ||
| </Form.Item> | ||
| <Form.Item label={t('plivo_request_config.timeout')} name={[...names, 'timeout']}> | ||
| <InputNumber min={0} className='w-full' /> | ||
| </Form.Item> | ||
| <Form.Item label={t('plivo_request_config.retry_times')} name={[...names, 'retry_times']}> | ||
| <InputNumber min={1} className='w-full' /> | ||
| </Form.Item> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Make voice-only fields optional.
plivo-smsdefaults omitanswer_urlandanswer_method, but this interface requires both. A valid SMS configuration therefore cannot satisfyChannelItem. Make them optional; constrainanswer_methodto'GET' | 'POST'.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents