Skip to content

fix: bind Agent Attention delivery to Codex task #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myagentdojo merged 1 commit into from
Aug 12, 2026
Merged

fix: bind Agent Attention delivery to Codex task #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions experiments/agent-attention/runtime/agent-attention/agent-attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,16 +1405,18 @@ def record_delivery(args: argparse.Namespace) -> dict[str, Any]:
return base_result("already_delivered", changed=False, event_id=identifier)
if not claim_path.exists():
raise ContractError("cannot record delivery without an existing claim")
claim = validate_event_binding(
load_json(claim_path), identifier, document_name="delivery claim"
)
try:
tool_result = json.loads(args.tool_result)
except json.JSONDecodeError as error:
raise ContractError("tool result must be valid JSON") from error
if not isinstance(tool_result, dict) or tool_result.get("delivered") is not True:
raise ContractError("tool result does not confirm delivery")

claim = validate_event_binding(
load_json(claim_path), identifier, document_name="delivery claim"
)
if (
not isinstance(tool_result, dict)
or tool_result.get("threadId") != claim["thread_id"]
):
raise ContractError("tool result does not confirm exact task delivery")
receipt = {
**claim,
"delivered_at": datetime.now(timezone.utc).isoformat(),
Expand Down
48 changes: 44 additions & 4 deletions experiments/agent-attention/runtime/agent-attention/test_agent_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
OTHER_REMINDER_ID = "22222222-2222-4222-8222-222222222222"
NEW_REMINDER_ID = "33333333-3333-4333-8333-333333333333"
THREAD_ID = "019fc54e-ff95-7ca1-af49-5720c36fdc0d"
OTHER_THREAD_ID = "019fc54e-ff95-7ca1-af49-5720c36fdc0e"
APPROVAL_MEANING = "Approve the bounded outcome-receipt test only."
FINISHED_AT = "2026-08-10T05:45:00Z"

Expand Down Expand Up @@ -1245,7 +1246,7 @@ def test_watch_detects_and_records_delivery_under_fifteen_seconds(self) -> None:
"--event-id",
result["event_id"],
"--tool-result",
'{"delivered":true,"fixture":"exact-task"}',
json.dumps({"threadId": THREAD_ID}),
)
)
self.assertEqual(recorded["status"], "recorded")
Expand Down Expand Up @@ -1575,7 +1576,41 @@ def test_doctor_requires_the_plist_selected_executable_for_readiness(self) -> No
self.assertEqual(ready["status"], "ready")
self.assertTrue(ready["link_handler"]["installed"])

def test_record_delivery_rejects_invalid_event_ids_and_non_boolean_proof(self) -> None:
def test_record_delivery_accepts_codex_exact_task_result(self) -> None:
claim_dir = self.state_dir / "claims"
claim_dir.mkdir()
identifier = self._event_id()
receipt_path = self.state_dir / "receipts" / f"{identifier}.json"
receipt_path.unlink()
(claim_dir / f"{identifier}.json").write_text(
json.dumps(
{
"event_id": identifier,
"reminder_id": REMINDER_ID,
"thread_id": THREAD_ID,
"approval_meaning": APPROVAL_MEANING,
}
),
encoding="utf-8",
)

result = self.result(
self.run_cli(
"record-delivery",
"--event-id",
identifier,
"--tool-result",
json.dumps({"threadId": THREAD_ID}),
)
)

self.assertEqual(result["status"], "recorded")
self.assertEqual(
json.loads(receipt_path.read_text())["tool_result"],
{"threadId": THREAD_ID},
)

def test_record_delivery_rejects_invalid_event_ids_and_unbound_proof(self) -> None:
for invalid_id in ("../requests/forged", "A" * 64, "0" * 63):
with self.subTest(event_id=invalid_id):
completed = self.run_cli(
Expand Down Expand Up @@ -1603,7 +1638,12 @@ def test_record_delivery_rejects_invalid_event_ids_and_non_boolean_proof(self) -
),
encoding="utf-8",
)
for tool_result in ('{"delivered":"false"}', '{"delivered":1}', '[]'):
for tool_result in (
'{"delivered":true}',
json.dumps({"threadId": OTHER_THREAD_ID}),
json.dumps({"thread_id": THREAD_ID}),
'[]',
):
with self.subTest(tool_result=tool_result):
completed = self.run_cli(
"record-delivery",
Expand All @@ -1613,7 +1653,7 @@ def test_record_delivery_rejects_invalid_event_ids_and_non_boolean_proof(self) -
tool_result,
)
self.assertEqual(completed.returncode, 1)
self.assertIn("does not confirm delivery", completed.stderr)
self.assertIn("does not confirm exact task delivery", completed.stderr)

def test_record_delivery_rejects_incomplete_existing_receipt_before_reconciliation(self) -> None:
request_dir = self.state_dir / "requests"
Expand Down
14 changes: 8 additions & 6 deletions plugin/runtime/agent-attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,16 +1405,18 @@ def record_delivery(args: argparse.Namespace) -> dict[str, Any]:
return base_result("already_delivered", changed=False, event_id=identifier)
if not claim_path.exists():
raise ContractError("cannot record delivery without an existing claim")
claim = validate_event_binding(
load_json(claim_path), identifier, document_name="delivery claim"
)
try:
tool_result = json.loads(args.tool_result)
except json.JSONDecodeError as error:
raise ContractError("tool result must be valid JSON") from error
if not isinstance(tool_result, dict) or tool_result.get("delivered") is not True:
raise ContractError("tool result does not confirm delivery")

claim = validate_event_binding(
load_json(claim_path), identifier, document_name="delivery claim"
)
if (
not isinstance(tool_result, dict)
or tool_result.get("threadId") != claim["thread_id"]
):
raise ContractError("tool result does not confirm exact task delivery")
receipt = {
**claim,
"delivered_at": datetime.now(timezone.utc).isoformat(),
Expand Down