Repository navigation
Conversation
|
@Frezc is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Archiving an agent with a long unbroken name can expand the confirmation header and footer past the popup. A 384px popup can end up with a ~456px footer, leaving the Archive button outside its surface; longer names can push the buttons outside the viewport.
Keep the full name visible by wrapping it inside the popup. Constrain the shared AlertDialog grid to one shrinking column, allow long title/description words to wrap, and let the archive text column shrink. Apply explicit name breaking to both row and bulk archive titles so mixed CJK/ASCII names do not leave an orphaned leading character.
Related Issue
Found while testing agent archive confirmation with long names. No matching public issue or fix PR found; #8209 addresses vertical dialog height and does not fix this horizontal overflow.
Type of Change
Changes Made
packages/ui/components/ui/alert-dialog.tsx: usegrid-cols-1for aminmax(0, 1fr)content track andwrap-anywherefor titles/descriptions.packages/views/agents/components/agent-row-actions.tsx: shrink the archive text column and break long archive titles.packages/views/agents/components/agent-batch-toolbar.tsx: break long names in the bulk archive title.How to Test
RELEASE_ACCEPTANCE_AGENT_WITH_A_VERY_LONG_NAME.Verified on upstream
mainat8db6cfe19plus this patch:pnpm --filter @multica/views exec vitest run agents/components/agent-batch-toolbar.test.tsx agents/components/agent-detail-page.test.tsx --maxWorkers=1: 24 tests passed in exactly two files.git diff --checkpassed.Full verification report
The browser fixture uses the real UI primitives, shared styles, locale copy and archive dialog composition. It does not exercise the full Agents page or archive API. The full root suite, deployed E2E and installed Electron were not run. This CSS-only fix adds no class-string unit tests; real browser geometry checks provide layout verification. Shared AlertDialog word wrapping also affects other callers; short names were included in the matrix.
Checklist
AI Disclosure
AI tool used: Codex
Prompt / approach: Reproduce the reported archive dialog overflow, check whether upstream already has a matching fix, port the focused CSS change onto current upstream main, and verify with Chromium geometry checks plus existing component tests.
Screenshots
Before (synthetic long name):
After (the complete name wraps inside the popup):