[material-ui][Pagination] Add tests for page links near the edges - #49120
Draft
Janpot wants to merge 1 commit into
Draft
[material-ui][Pagination] Add tests for page links near the edges#49120Janpot wants to merge 1 commit into
Janpot wants to merge 1 commit into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
boundaryCount={0} siblingCount={0}we lose a page link when the current page is one of the first two or last two. On an 11-page pagination, page 1 loses the link to page 2. It happens at every count from 4 up. These tests pass on master and fail on #49090.Two of them matter most: the edge invariant here and the button-count test in
Pagination.test.js. They also pass under a fix that just strips the ellipses and keeps the links, so they don't assume one implementation. The three deep-equal tests pin the ellipses too, so any version of this feature will need to update them.Draft because it may be easier to fold these into #49090.