Skip to content

[autocomplete] update default listbox paper elevation - #49110

Open
namansancheti wants to merge 1 commit into
mui:masterfrom
namansancheti:48933
Open

[autocomplete] update default listbox paper elevation#49110
namansancheti wants to merge 1 commit into
mui:masterfrom
namansancheti:48933

Conversation

@namansancheti

Copy link
Copy Markdown

Fixes #48933

@code-infra-dashboard

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-49110--material-ui.netlify.app/
QR code for https://deploy-preview-49110--material-ui.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/material 🔺+30B(+0.01%) 🔺+7B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@namansancheti

Copy link
Copy Markdown
Author

The label breaking change needs to be added, but I don't seem to have the permission to add:

namans@Namans-MacBook-Pro material-ui % gh pr edit 49110 --add-label "breaking change"
GraphQL: namansancheti does not have the correct permissions to execute AddLabelsToLabelable (addLabelsToLabelable)

@namansancheti

Copy link
Copy Markdown
Author

Also, per my understanding the major version will get bumped automatically, once the breaking change label is added ?

(Ref: https://mui.com/material-ui/getting-started/versions/#versioning-strategy)

@silviuaavram

Copy link
Copy Markdown
Member

Thanks @namansancheti !

@silviuaavram silviuaavram added the breaking change Introduces changes that are not backward compatible. label Sep 9, 2026
@silviuaavram
silviuaavram requested a balanced review from Copilot September 9, 2026 06:15
@silviuaavram

Copy link
Copy Markdown
Member

@claude review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The breaking visual change and unresolved migration-documentation concern warrant human review.

Pull request overview

Updates Autocomplete popup elevation to align with Select/Menu.

Changes:

  • Changes the default Paper elevation from 1 to 8.
  • Tests default and custom elevation behavior.
  • Requires migration documentation for preserving the previous appearance.
File summaries
File Description
packages/mui-material/src/Autocomplete/Autocomplete.test.js Tests default and overridden elevations.
packages/mui-material/src/Autocomplete/Autocomplete.js Sets elevation to 8; migration guidance remains requested.
Review details

Suppressed comments (1)

packages/mui-material/src/Autocomplete/Autocomplete.js:622

  • This changes the rendered shadow for every Autocomplete and is explicitly tracked as a breaking change, but the active v9 migration guide has no corresponding entry. Please document the elevation change from 1 to 8 under Autocomplete and show slotProps={{ paper: { elevation: 1 } }} for consumers who need to preserve the previous appearance.
      elevation: 8,
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@namansancheti

Copy link
Copy Markdown
Author

@silviuaavram
Thanks for reviewing - noticed the comment above by Copilot AI regarding migration guide update and the visual change.

Please let me know, in case any additional changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. v10.x

Projects

None yet

4 participants