[autocomplete] update default listbox paper elevation - #49110
[autocomplete] update default listbox paper elevation#49110namansancheti wants to merge 1 commit into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
|
The label
|
|
Also, per my understanding the (Ref: https://mui.com/material-ui/getting-started/versions/#versioning-strategy) |
|
Thanks @namansancheti ! |
|
@claude review |
There was a problem hiding this comment.
🔵 Needs a closer look
The breaking visual change and unresolved migration-documentation concern warrant human review.
Pull request overview
Updates Autocomplete popup elevation to align with Select/Menu.
Changes:
- Changes the default Paper elevation from 1 to 8.
- Tests default and custom elevation behavior.
- Requires migration documentation for preserving the previous appearance.
File summaries
| File | Description |
|---|---|
packages/mui-material/src/Autocomplete/Autocomplete.test.js |
Tests default and overridden elevations. |
packages/mui-material/src/Autocomplete/Autocomplete.js |
Sets elevation to 8; migration guidance remains requested. |
Review details
Suppressed comments (1)
packages/mui-material/src/Autocomplete/Autocomplete.js:622
- This changes the rendered shadow for every Autocomplete and is explicitly tracked as a breaking change, but the active v9 migration guide has no corresponding entry. Please document the elevation change from 1 to 8 under Autocomplete and show
slotProps={{ paper: { elevation: 1 } }}for consumers who need to preserve the previous appearance.
elevation: 8,
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@silviuaavram Please let me know, in case any additional changes are required. |
Fixes #48933