Skip to content

[material-ui][Pagination] Hide ellipses with zero boundary and sibling counts #49090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lprnmns wants to merge 3 commits into
base: master
Choose a base branch
from
+28 −26
Open

[material-ui][Pagination] Hide ellipses with zero boundary and sibling counts #49090

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce2f9a2
[material-ui][Pagination] Hide ellipses with zero boundary and siblin…
lprnmns Sep 4, 2026
c582ee4
Merge branch 'master' into codex/fix-pagination-zero-boundaries
Janpot Sep 9, 2026
f34b0a1
[material-ui][Pagination] Handle compact pagination edge cases
lprnmns Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions packages/mui-material/src/usePagination/usePagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,28 +71,32 @@ export default function usePagination(props = {}) {
const itemList = [
...(showFirstButton ? ['first'] : []),
...(hidePrevButton ? [] : ['previous']),
...startPages,
...(boundaryCount === 0 && siblingCount === 0
? [page]
: [
...startPages,

// Start ellipsis
// eslint-disable-next-line no-nested-ternary
...(siblingsStart > boundaryCount + 2
? ['start-ellipsis']
: boundaryCount + 1 < count - boundaryCount
? [boundaryCount + 1]
: []),
// Start ellipsis
// eslint-disable-next-line no-nested-ternary
...(siblingsStart > boundaryCount + 2
? ['start-ellipsis']
: boundaryCount + 1 < count - boundaryCount
? [boundaryCount + 1]
: []),

// Sibling pages
...range(siblingsStart, siblingsEnd),
// Sibling pages
...range(siblingsStart, siblingsEnd),

// End ellipsis
// eslint-disable-next-line no-nested-ternary
...(siblingsEnd < count - boundaryCount - 1
? ['end-ellipsis']
: count - boundaryCount > boundaryCount
? [count - boundaryCount]
: []),
// End ellipsis
// eslint-disable-next-line no-nested-ternary
...(siblingsEnd < count - boundaryCount - 1
? ['end-ellipsis']
: count - boundaryCount > boundaryCount
? [count - boundaryCount]
: []),

...endPages,
...endPages,
]),
...(hideNextButton ? [] : ['next']),
...(showLastButton ? ['last'] : []),
];
Expand Down
8 changes: 1 addition & 7 deletions packages/mui-material/src/usePagination/usePagination.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,7 @@ describe('usePagination', () => {
items = renderHook(() =>
usePagination({ count: 11, page: 6, boundaryCount: 0, siblingCount: 0 }),
).result.current.items;
expect(serialize(items)).to.deep.equal([
'previous',
'start-ellipsis',
6,
'end-ellipsis',
'next',
]);
expect(serialize(items)).to.deep.equal(['previous', 6, 'next']);

items = renderHook(() =>
usePagination({ count: 11, page: 6, boundaryCount: 0, siblingCount: 1 }),
Expand Down
Loading