Skip to content

Fix type hint for Table.update transform callback - #627

Open
jayasree-007 wants to merge 1 commit into
msiemens:masterfrom
jayasree-007:fix-update-type-hints
Open

Fix type hint for Table.update transform callback#627
jayasree-007 wants to merge 1 commit into
msiemens:masterfrom
jayasree-007:fix-update-type-hints

Conversation

@jayasree-007

Copy link
Copy Markdown

Summary

Update the type hint for the Table.update transform callback from
Callable[[Mapping], None] to Callable[[MutableMapping], None].

The callback is expected to mutate the document in place. Existing usage,
including the delete transform, performs operations such as del on the
document, which requires a MutableMapping rather than a Mapping.

This change aligns the type annotation with the actual behavior.

Testing

  • Ran the full test suite.
  • All tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant