Skip to content

fix: LRUCache.get() and __getitem__() fail for cached None values #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koteshyelamati wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −9
Open

fix: LRUCache.get() and __getitem__() fail for cached None values #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions tinydb/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,24 +78,23 @@ def __delitem__(self, key: K) -> None:
del self.cache[key]

def __getitem__(self, key) -> V:
value = self.get(key)
if value is None:
if key not in self.cache:
raise KeyError(key)
value = self.cache[key]
self.cache.move_to_end(key, last=True)

return value

def __iter__(self) -> Iterator[K]:
return iter(self.cache)

def get(self, key: K, default: Optional[D] = None) -> Optional[Union[V, D]]:
value = self.cache.get(key)
if key not in self.cache:
return default
value = self.cache[key]
self.cache.move_to_end(key, last=True)

if value is not None:
self.cache.move_to_end(key, last=True)

return value

return default
return value

def set(self, key: K, value: V):
if key in self.cache:
Expand Down