Bug 1499551 - Fix accumulating window event-listener leaks (part 1/3) - #9704
Open
camd wants to merge 2 commits into
Open
Bug 1499551 - Fix accumulating window event-listener leaks (part 1/3)#9704camd wants to merge 2 commits into
camd wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9704 +/- ##
========================================
Coverage 82.66% 82.67%
========================================
Files 626 626
Lines 36753 36757 +4
Branches 3348 3276 -72
========================================
+ Hits 30383 30389 +6
- Misses 5988 6218 +230
+ Partials 382 150 -232 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 3 addressing Bug 1499551 (jobs-view memory/CPU growth over time).
Two class components added a
windowevent listener with an anonymous handler and nocomponentWillUnmount, so each mount permanently accumulated a listener (and its captured component instance):FailureSummaryTab(internalIssueClassification) — remounts on every job selection.GraphsContainer(resize) — remounts on every test/time-range change.Both now store the handler as a stable class-property arrow and remove that same reference on unmount.
GraphsContainer's resize handler recomputeszoomDomainfrom currentscatterPlotData(via the existinginitZoomDomain) instead of capturing a stale mount-time value.Independent of the other two Bug 1499551 PRs.
Testing