Add submitted pings table - #3585
Merged
Merged
Conversation
Member
Author
|
Some changes:
|
badboy
requested changes
Aug 14, 2026
badboy
left a comment
badboy
left a comment
Member
There was a problem hiding this comment.
this is starting to look pretty good (did a full review this time).
A few more things.
Right now getting those pings back from the outside is not implemented, but I assume that's gonna be done in a followup?
jeddai
force-pushed
the
add-submitted_pings-table
branch
from
August 21, 2026 19:05
edced9d to
0f436f4
Compare
badboy
reviewed
Sep 3, 2026
badboy
left a comment
badboy
left a comment
Member
There was a problem hiding this comment.
No major blocker anymore. Couple of questions.
You can also rebase this branch on main and squash down the commits.
jeddai
force-pushed
the
add-submitted_pings-table
branch
from
September 15, 2026 14:07
02263b7 to
f8a5477
Compare
badboy
approved these changes
Sep 17, 2026
…hods # Conflicts: # glean-core/src/database/sqlite.rs
# Conflicts: # glean-core/benchmark/benches/dispatcher.rs # glean-core/benchmark/benches/lifetime_buffering.rs
badboy
force-pushed
the
add-submitted_pings-table
branch
from
September 17, 2026 08:57
fd54f21 to
b3235cb
Compare
Member
|
Rebased and fixed up the changelog, will merge when CI passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening from #3575