Skip to content
This repository was archived by the owner on Jan 31, 2018. It is now read-only.

Requesting a pull to mozilla:master from k88hudson:t3323 #1556

Open
k88hudson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Requesting a pull to mozilla:master from k88hudson:t3323 #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions css/editors.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,7 @@ textarea {
&.small {
background: none;
border: none;
box-shadow: none;

@k88hudson k88hudson Mar 7, 2013

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the lefthand side to look flat instead of rounded

&:after {
content: "";
display: block;
Expand Down
14 changes: 4 additions & 10 deletions src/editor/sequencer-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,16 +202,10 @@ define( [ "util/mediatypes", "editor/editor", "util/time",
clipSection.classList.remove( "small" );
}

if ( options.from ) {
clipSection.style.left = timeToPosition( from ) + "px";
inInput.value = Time.toTimecode( from );
outInput.value = Time.toTimecode( from + end - start );
}

if ( options.end || options.start ) {
clipSection.style.width = timeToPosition( end - start ) + "px";
outInput.value = Time.toTimecode( from + end - start );
}
clipSection.style.left = timeToPosition( from ) + "px";

@k88hudson k88hudson Mar 7, 2013

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was not allowing 0, but honestly it's not that bad to just always update everything

clipSection.style.width = timeToPosition( end - start ) + "px";
inInput.value = Time.toTimecode( from );
outInput.value = Time.toTimecode( from + end - start );

if ( options.duration ) {
clipEndLable.innerHTML = Time.toTimecode( options.duration );
Expand Down