Skip to content

Add abstract TransportFactory - #205

Merged
mosquito merged 5 commits into
mosquito:masterfrom
ozobotnovako:feature/transport-factory
Jul 22, 2025
Merged

Add abstract TransportFactory#205
mosquito merged 5 commits into
mosquito:masterfrom
ozobotnovako:feature/transport-factory

Conversation

@ozobotnovako

Copy link
Copy Markdown
Contributor

Hi @mosquito , this PR aims to add an (optional) abstract TransportFactory letting users to implement alternative transports.

This PR is an alternative to #197 that brings less changes and is (hopefully) easier to merge.

@ozobotnovako

Copy link
Copy Markdown
Contributor Author

Hi @mosquito, have you had a chance to take a look on this, please? Is there something I can do to get this merged? In case you are not interested in this feature or you don't have time to do the review, I'll just close this to clean up the PR log.

@mosquito mosquito left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this PR happened during my big move and got lost in the mail. Let's discuss everything in the comments to code-review

Comment thread aiormq/connection.py Outdated
Comment thread aiormq/connection.py Outdated
Comment thread aiormq/connection.py Outdated
Comment thread aiormq/connection.py Outdated
Comment thread aiormq/connection.py
@ozobotnovako

Copy link
Copy Markdown
Contributor Author

Thanks for your comments @mosquito .

You are right with the is_ssl_url unclear purpose. Originally I made it this way to know when to create the SSL context in the connection object, but I have created SSLContextProvider instead. I also split the TCP and TLS factories as suggested.

I just wish I could add some tests that would use a different protocol such as udp, or tcp with inverse data, however this would require a proxy code that would convert the traffic back, so I'm not sure this is worth it.

@ozobotnovako
ozobotnovako requested a review from mosquito July 10, 2025 12:03
@ozobotnovako

Copy link
Copy Markdown
Contributor Author

@mosquito , I have fixed the linter error. Could you please re-run the workflow?

Comment thread aiormq/connection.py Outdated
@ozobotnovako
ozobotnovako requested a review from mosquito July 21, 2025 08:34
@ozobotnovako
ozobotnovako force-pushed the feature/transport-factory branch from 15735d7 to 0e0a4ec Compare July 21, 2025 09:01
Comment thread aiormq/connection.py
@mosquito
mosquito merged commit 934b1a5 into mosquito:master Jul 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants