Skip to content

MOSIP-45683 - Removed hardcoded version from JAR name and run instructions - #1087

Merged
Ivanmeneges merged 1 commit into
mosip:developfrom
mohanachandran-s:MOSIP-45630-version-free
Oct 21, 2026
Merged

Ivanmeneges merged 1 commit into
mosip:developfrom
mohanachandran-s:MOSIP-45630-version-free

Conversation

@mohanachandran-s

@mohanachandran-s mohanachandran-s commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

MOSIP-45683 - Removed hardcoded version from JAR name and run instructions

  • pom: <fileName> is now ${project.artifactId}-${project.version}-jar-with-dependencies, so a version bump only changes <version>. The resolved JAR name is unchanged, and the Dockerfile and entrypoint already use the * wildcard.
  • README: the run command uses the *-jar-with-dependencies.jar wildcard (with a PowerShell variant), the duplicate -jar is removed, and the "jar" note says the version comes from pom.xml.

Same change as resident-services mosip/resident-services#1678.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated JAR execution instructions with separate commands for Linux, macOS, Git Bash, and Windows PowerShell.
    • Clarified the versioned JAR naming pattern and how the commands accommodate version changes.
  • Chores
    • JAR filenames now reflect the project’s artifact name and version.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a04d8f2d-7ad4-4b84-9c9e-e4107f2079f1
📥 Commits

Reviewing files that changed from the base of the PR and between 489a9d9 and c995da0.

📒 Files selected for processing: 2
  • api-test/README.md
  • api-test/pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The shaded JAR filename now derives from the Maven project artifact ID and version. The README documents wildcard-based execution commands for Unix-like shells and PowerShell, and explains the versioned JAR naming pattern.

Changes

API Test JAR Execution

Layer / File(s) Summary
JAR naming and execution instructions
api-test/pom.xml, api-test/README.md
The shaded JAR filename uses the project artifact ID and version. The README provides commands for Unix-like shells and PowerShell and describes the versioned filename pattern.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~7 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to c995d

The versioned JAR name remains compatible with the README commands. No new merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main changes: removing the hardcoded JAR version from the filename and run instructions.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A JAR name follows the build,
Its version appears in the name.
Unix shells pass the wildcard,
PowerShell finds the matching file.
Run commands need not chase versions.

Comment @coderabbitai help to get the list of available commands.

…tions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
@mohanachandran-s
mohanachandran-s force-pushed the MOSIP-45630-version-free branch from b9267e4 to c995da0 Compare October 16, 2026 12:19
@mohanachandran-s mohanachandran-s changed the title MOSIP-45630 - Removed hardcoded version from JAR name and run instructions MOSIP-45683 - Removed hardcoded version from JAR name and run instructions Oct 16, 2026
@Ivanmeneges
Ivanmeneges merged commit b1691c2 into mosip:develop Oct 21, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants