scripts: make Nyx VM memory size configurable - #169
Conversation
erickcestari
left a comment
There was a problem hiding this comment.
LGTM! Maybe we could also reduce the default value. I haven't tested other values, but a lower default should make it easier to run more fuzzing jobs in parallel.
I have a dedicated server with 62 GiB of RAM, and it can run at most 15 fuzzing instances simultaneously.
Agreed. I've ran a lot of trials with 2048 as the image size and haven't ever had any problems with it, but I remember @NishantBansal2003 telling me once that it caused some issues with his setup for Eclair or CLN. I personally prefer that as the default value and can vouch for it working fine, but let us see what others have to say. |
NishantBansal2003
left a comment
There was a problem hiding this comment.
Looks good!
Agreed. I've ran a lot of trials with 2048 as the image size and haven't ever had any problems with it, but I remember @NishantBansal2003 telling me once that it caused some issues with his setup for Eclair or CLN.
I had issues with the nested virtualization setup, though the machine specs were not quite good, so I didn’t expect good results. On my dedicated machine, I lowered the VM size to 2048 and tried running the CLN campaign, and I haven’t faced any issues though
The memory allocation for Nyx VM instances is hardcoded to 4096 MB during the packer configuration generation step. Introduce the `NYX_MEM_MB` environment variable, allowing users to dynamically scale the VM memory down for resource-constrained deployments such as parallel fuzzing trials. Use the default as 2048 MB fallback if the variable is unset and `echo` the chosen size to stdout for better setup observability.
|
Since no one seems to have a problem with it, I have changed the default to 2048 MB. |
morehouse
left a comment
There was a problem hiding this comment.
Tested the lower 2GB memory limit by fuzzing the IR scenario against all targets for 1h. No issues encountered.
The memory allocation for Nyx VM instances is hardcoded to 4096 MB during the packer configuration generation step.
Introduce the
VM_SIZEenvironment variable, allowing users to dynamically scale the VM memory down for resource-constrained deployments such as parallel fuzzing trials.Retain the default 4096 MB fallback if the variable is unset and
echothe chosen size to stdout for better setup observability.