smite: add commitment_signed codec - #167
Merged
Merged
Conversation
Comment on lines
+49
to
+54
| u16::try_from(self.htlc_signatures.len()) | ||
| .expect("number of HTLC signatures must not exceed u16::MAX") | ||
| .write(&mut out); | ||
| for htlc_signature in &self.htlc_signatures { | ||
| htlc_signature.write(&mut out); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I inlined the Vec<Signature> encode/decode logic since no other wire messages share this type, so I didn't think it made sense to implement WireFormat for it
Let me know if you'd prefer consistency here and would rather have WireFormat implemented instead
erickcestari
approved these changes
Jul 28, 2026
erickcestari
left a comment
erickcestari
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just a very small nit that would be fine if not addressed.
NishantBansal2003
force-pushed
the
commit-sign-codec
branch
from
July 29, 2026 11:49
8db7db3 to
544b216
Compare
morehouse
approved these changes
Jul 30, 2026
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
NishantBansal2003
force-pushed
the
commit-sign-codec
branch
from
July 31, 2026 07:11
544b216 to
3cface7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #111