Fix missing shift modifier for plus key#1582
Open
ReenigneArcher wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Originally tested with Sunshine on Windows. Confirmed the same behavior with Sunshine on Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending the "+" key from the Android OSK, it would result in an "=" in Sunshine. This PR adds a function to allow applying modifiers to various keys to resolve this issue.
I checked all other keys/symbols on the OSK and no others had this same issue.
Note: I tried to test this change in Android Studio with Android Emulator, but Moonlight is very slow there and I wasn't able to bring up the OSK.