fix(builtin): seed hashes from platform entropy - #4160
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 540cb8d90d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Coverage Report for CI Build 6542Coverage decreased (-0.02%) to 89.19%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
peter-jerry-ye
force-pushed
the
codex/add-process-hash-seed
branch
from
September 2, 2026 08:24
540cb8d to
8417fa8
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
bobzhang
force-pushed
the
codex/add-process-hash-seed
branch
from
September 3, 2026 07:41
8417fa8 to
789cbfa
Compare
bobzhang
reviewed
Sep 3, 2026
| ///| | ||
| // `builtin` cannot depend on `env`, so bind the runtime entropy source here. | ||
| #cfg(any(target="native", target="llvm")) | ||
| fn random_seed_native() -> Int? { |
peter-jerry-ye
force-pushed
the
codex/add-process-hash-seed
branch
2 times, most recently
from
September 3, 2026 08:09
1bd8256 to
fc0cb58
Compare
bobzhang
force-pushed
the
codex/add-process-hash-seed
branch
from
September 3, 2026 13:38
fc0cb58 to
d887241
Compare
bobzhang
enabled auto-merge (rebase)
September 3, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hasher()already uses a process-wide random seed on JavaScript, while native and LLVM use a fixed zero seed. That leaves hash-table layouts predictable on those native backends and allows collision sets to be prepared in advance.What
seed=0.Why this is correct and minimal
The change binds the existing runtime entropy source directly in
builtin, avoiding a dependency cycle throughenv. It changes only the default process seed on native and LLVM; explicit seeds and the hashing algorithm remain unchanged.Linear Wasm is deliberately excluded because eager module initialization can run before a Preview 1 component adapter is fully wired. Wasm protection and collision-triggered per-table randomization remain separate follow-up design work.