-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add wasm-gc support for timer, event loop, and time #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
duobei
wants to merge
5
commits into
moonbitlang:main
Choose a base branch
from
duobei:feat/wasm-gc-timer-event-loop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0f15d84
feat: add wasm-gc support for timer, event loop, and time
duobei a7a6d9a
docs: fix wasm-gc-imports.js header comment
duobei 9c46caf
ci: retry flaky sanitizer-check-windows
duobei 5fae260
ci: retry
duobei 8d0e632
refactor: merge js/wasm-gc timer and event_loop files using #cfg
duobei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Copyright 2025 International Digital Economy Academy | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| ///| | ||
| let _ignore_unused_import : Unit = { | ||
| ignore(@c_buffer.unimplemented) | ||
| ignore(@fd_util.unimplemented) | ||
| ignore(@os_string.unimplemented) | ||
| ignore(@os_error.unimplemented) | ||
| ignore(@time.ms_since_epoch) | ||
| } | ||
|
|
||
| ///| | ||
| pub fn reschedule() -> Unit { | ||
| guard !@coroutine.no_more_work() else { } | ||
| @coroutine.reschedule() | ||
| // Instead of looping blockingly until there is no ready task, | ||
| // we only perform one round of scheduling here | ||
| // (i.e., only those tasks already ready when `reschedule` is called are run). | ||
| // Remaining tasks are delayed until the next event loop iteration, | ||
| // so that those blocking jobs got a chance to execute instead of starving. | ||
| if @coroutine.has_immediately_ready_task() { | ||
| ignore(wasm_set_timeout(0, reschedule)) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Copyright 2025 International Digital Economy Academy | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| ///| | ||
| #external | ||
| type Timer | ||
|
|
||
| ///| | ||
| fn wasm_set_timeout(duration : Int, f : () -> Unit) -> Timer = "moonbitlang_async_timer" "set_timeout" | ||
|
|
||
| ///| | ||
| fn wasm_clear_timeout(timer : Timer) = "moonbitlang_async_timer" "clear_timeout" | ||
|
|
||
| ///| | ||
| pub fn Timer::new(duration : Int, f : () -> Unit) -> Timer { | ||
| wasm_set_timeout(duration, () => { | ||
| f() | ||
| reschedule() | ||
| }) | ||
| } | ||
|
|
||
| ///| | ||
| pub fn Timer::cancel(self : Timer) -> Unit { | ||
| wasm_clear_timeout(self) | ||
| } | ||
|
duobei marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Import objects for moonbitlang/async wasm-gc timer, event loop, and time modules. | ||
| // When loading the compiled wasm-gc module, merge these into the import object: | ||
| // | ||
| // import { moonbitlang_async_timer, moonbitlang_async_time } from "./wasm-gc-imports.js"; | ||
| // const imports = { ...otherImports, moonbitlang_async_timer, moonbitlang_async_time }; | ||
| // const { instance } = await WebAssembly.instantiateStreaming(fetch("module.wasm"), imports); | ||
|
|
||
| export const moonbitlang_async_timer = { | ||
| set_timeout: (duration, f) => setTimeout(f, duration), | ||
| clear_timeout: (timer) => clearTimeout(timer), | ||
|
duobei marked this conversation as resolved.
Outdated
|
||
| }; | ||
|
|
||
| export const moonbitlang_async_time = { | ||
| date_now: () => Date.now(), | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.