Conversation
Centralize variable-length native text reads and retry buffer negotiation when mutable state grows between calls.
Stage app bundles under their final names and omit AppleDouble resource-fork metadata from generated ZIP archives.
Milky2018
marked this pull request as ready for review
July 30, 2026 10:18
proton_engine_bridge_pending_cancel still referenced the pre-rename g_bridge_pending symbol, breaking the win32 engine build (C2065).
Resolve overlaps between the bridge cancellation/origin work and main: - invokeOp (win/mac/linux): keep the 5-arg action dispatch, validate page_instance via the shared proton_engine_bridge_page_instance_is_valid helper from cef_common/bridge_json.h. - notification poll click: keep the read_native_text refactor, which also covers the exact-span decode hardening from main. - scaffold shared module: drop supported_targets (target-neutral) and keep preferred_target js so bare moon check uses a proven backend. - regenerate cli/new/templates.generated.mbt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.appbasename and without__MACOSXor AppleDouble metadata entriesBackground
Several independent correctness issues remained in generated projects and native/package boundaries:
PROTON_ERROR_BUFFER_TOO_SMALL.staging.appname and usedditto --sequesterRsrc --keepParent, which preserved the temporary root name and intentionally added__MACOSXmetadata to the archiveImplementation
ditto --norsrc --keepParentImpact
Generated isomorphic projects keep their contracts available to every consumer target. Native reads no longer turn a normal size race into an application startup failure. macOS ZIP artifacts now contain the expected application root and no hidden staging root,
__MACOSX, or._entries; the.appitself is unchanged.Validation
moon -C cli test -p justjavac/proton_cli/package --target native --no-parallelize --diagnostic-limit 80moon -C cli check --target native --diagnostic-limit 80moon fmt --checkgit diff --checkexamples/47_dev_extension_jsas.appand.zipzipinfo -1codesign --verify --deep --strict --verbose=2