GODRIVER-4025 fix: Preserve first writeConcernError in unordered bulk write#2484
Open
zigzagdev wants to merge 1 commit into
Open
GODRIVER-4025 fix: Preserve first writeConcernError in unordered bulk write#2484zigzagdev wants to merge 1 commit into
zigzagdev wants to merge 1 commit into
Conversation
matthewdale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-4025
Summary
In an unordered
BulkWritethat splits into multiple command batches, awriteConcernErrorreported by an earlier batch was discarded when a later batch succeeded without one.As a result the operation could return
nil(success) even though a durability guarantee was not met.Background & Motivation
For unordered bulk writes the loop runs every batch and assigns
bwErr.WriteConcernErroron each iteration, so only the last batch's value survives.When a later batch has no write concern error, it overwrites an earlier one with
niland the whole operation reports success — silently dropping a durability failure.The first write concern error that is detected should be retained instead of being overwritten.