GODRIVER-3892 Move count to the mongo package.#2483
Open
matthewdale wants to merge 1 commit into
Open
Conversation
Contributor
API Change Report./v2/x/mongo/driver/operationincompatible changesCount: removed |
Contributor
🧪 Performance ResultsCommit SHA: 969385aThe following benchmark tests for version 6a55a8a3108f4300076bcb05 had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
matthewdale
added
review-priority-low
matthewdale
force-pushed
the
godriver3892-move-count
branch
from
6e1c991 to
969385a
Compare
matthewdale
added
review-priority-normal
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the internal “count” operation implementation out of x/mongo/driver/operation and into the mongo package, simplifying EstimatedDocumentCount by removing the chainable setter style and keeping the moved types unexported.
Changes:
- Removed the legacy
Countoperation implementation fromx/mongo/driver/operation. - Added an unexported
countOpimplementation inmongo/to execute the count command and parse results. - Updated
Collection.EstimatedDocumentCountto construct and runcountOpdirectly, settingcomment/rawDatafields without setters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| x/mongo/driver/operation/count.go | Removes the previous Count operation implementation from the x/ operations layer. |
| mongo/op_count.go | Adds the new unexported countOp + result parsing logic in the mongo package. |
| mongo/collection.go | Switches EstimatedDocumentCount from operation.NewCount() to the new countOp struct literal wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return err | ||
| } | ||
|
|
||
| // Execute runs this operations and returns an error if the operation did not execute successfully. |
Comment on lines
+105
to
+107
| if c.deployment == nil { | ||
| return errors.New("the Count operation must have a Deployment set before Execute can be called") | ||
| } |
Comment on lines
+69
to
+80
| case "cursor": // for count using aggregate with $collStats | ||
| firstBatch, err := element.Value().Document().LookupErr("firstBatch") | ||
| if err != nil { | ||
| return cr, err | ||
| } | ||
|
|
||
| // get count value from first batch | ||
| val := firstBatch.Array().Index(0) | ||
| count, err := val.Document().LookupErr("n") | ||
| if err != nil { | ||
| return cr, err | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-3892
Summary
Move the count operation logic from the
x/mongo/driver/operationpackage to themongopackage, removing the unnecessary chainable setters. Don't export the moved types.Background & Motivation
Part of a larger effort to reduce unnecessary code by removing the
x/mongo/driver/operationpackage.