GODRIVER-3989 Add a drivers-evergreen-tools submodule with a pinned revision.#2466
Merged
Merged
Conversation
github-actions
Bot
added
the
review-priority-normal
matthewdale
force-pushed
the
godriver3989-pin-det
branch
from
a7b8b1f to
ed3cfbe
Compare
Contributor
API Change ReportNo changes found! |
Contributor
🧪 Performance ResultsCommit SHA: dd47122The following benchmark tests for version 6a55a91da17eec0007ffdf99 had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
github-actions
Bot
added
the
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
This PR pins drivers-evergreen-tools by adding it as a git submodule under .evergreen/ and updates supporting scripts/config so CI tooling uses that pinned revision and repo-wide tooling doesn’t get tripped up by the submodule.
Changes:
- Add
drivers-evergreen-toolsas a new submodule at.evergreen/drivers-evergreen-tools. - Update
.evergreen/setup-system.shto clonedrivers-evergreen-toolsat the submodule’s pinned revision. - Update license-checking to ignore hidden directories; attempt to update module behavior to ignore
.evergreen(needs adjustment).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
go.mod |
Attempts to add an ignore directive for .evergreen (currently invalid for go.mod and won’t affect gofumpt traversal). |
etc/check_license.sh |
Updates find invocation to ignore hidden directories when discovering .go files. |
.gitmodules |
Registers the new .evergreen/drivers-evergreen-tools submodule. |
.evergreen/setup-system.sh |
Clones drivers-evergreen-tools and checks out the pinned submodule revision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matthewdale
added
ci/cd
and removed
dependencies
qingyang-hu
requested changes
Jul 10, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
dependencies
qingyang-hu
approved these changes
Jul 13, 2026
qingyang-hu
reviewed
Jul 13, 2026
Contributor
There was a problem hiding this comment.
Looks like we need to bump to mongodb/libmongocrypt@c2f80a7 to fix the cmake version issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-3989
Summary
.evergreen/drivers-evergreen-tools.evergreen/setup-system.shto clone drivers-evergreen-tools based on the submodule revision.go.modwith anignoredirective for the./.evergreendir to forcegofumptto ignore Go code in the drivers-evergreen-tools submodule.etc/check_licenses.shscript to ignore directories starting with "."Background & Motivation
We want to pin the version of drivers-evergreen-tools so that test failures are isolated to code changes whenever possible, not changes in drivers-evergreen-tools.