Skip to content

chore: put windows back on normal 26.x MONGOSH-3480 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbbeeken merged 2 commits into from
Jul 8, 2026
Merged

chore: put windows back on normal 26.x MONGOSH-3480 #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44c510c
chore: put windows back on normal 26.x MONGOSH-3480
nbbeeken Jul 8, 2026
b3ee3c9
fix: keep node-gyp 13 but hold its undici at 7.x for Node 20 support
nbbeeken Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,7 @@ jobs:
- { node: 20.x, os: windows-2022, vs-version: '17', configure-args: vs2022 }
- { node: 22.x, os: windows-2022, vs-version: '17', configure-args: vs2022 }
- { node: 24.x, os: windows-2022, vs-version: '17', configure-args: vs2022 }
# TEMPORARY: Node 26.4.0 (latest release) fails to build with VS2026's
# Clang 22, which the libffi fix in nodejs/node#64222 addresses. That
# fix is on main but not yet in a v26.x release, so compile a main
# nightly that contains it to verify VS2026 works. Revert to a plain
# 26.x release once the fix lands in one.
- { node: 26.x, os: windows-latest, vs-version: '18', configure-args: vs2026, test-node-version: v27.0.0-nightly20260702b2e83150cb }
- { node: 26.x, os: windows-latest, vs-version: '18', configure-args: vs2026 }
test-to-run: ["works in a simple case","works with a Nan addon","works with a N-API addon","passes through env vars and runs the pre-compile hook","works with code caching support","works with snapshot support (compressBlobs = "]
runs-on: ${{ matrix.target.os }}
steps:
Expand Down Expand Up @@ -83,6 +78,3 @@ jobs:
env:
BOXEDNODE_MAKE_ARGS: "debug"
BOXEDNODE_CONFIGURE_ARGS: ${{ matrix.target.configure-args }}
# When set, boxednode compiles this exact version from source instead
# of the host Node.js version. Empty for release legs.
TEST_NODE_VERSION: ${{ matrix.target.test-node-version }}
10 changes: 1 addition & 9 deletions .github/workflows/nodejs.yml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,7 @@ jobs:
- { node: 20.x, os: windows-2022, vs-version: '17', configure-args: vs2022 }
- { node: 22.x, os: windows-2022, vs-version: '17', configure-args: vs2022 }
- { node: 24.x, os: windows-2022, vs-version: '17', configure-args: vs2022 }
# TEMPORARY: Node 26.4.0 (latest release) fails to build with VS2026's
# Clang 22, which the libffi fix in nodejs/node#64222 addresses. That
# fix is on main but not yet in a v26.x release, so compile a main
# nightly that contains it to verify VS2026 works. Revert to a plain
# 26.x release once the fix lands in one.
- { node: 26.x, os: windows-latest, vs-version: '18', configure-args: vs2026, test-node-version: v27.0.0-nightly20260702b2e83150cb }
- { node: 26.x, os: windows-latest, vs-version: '18', configure-args: vs2026 }
test-to-run: <<TEST_NAMES>>
runs-on: ${{ matrix.target.os }}
steps:
Expand Down Expand Up @@ -79,6 +74,3 @@ jobs:
env:
BOXEDNODE_MAKE_ARGS: "debug"
BOXEDNODE_CONFIGURE_ARGS: ${{ matrix.target.configure-args }}
# When set, boxednode compiles this exact version from source instead
# of the host Node.js version. Empty for release legs.
TEST_NODE_VERSION: ${{ matrix.target.test-node-version }}
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,10 @@
"rimraf": "^6.1.0",
"tar": "^7.5.19",
"yargs": "^16.0.3"
},
"overrides": {
"node-gyp": {
"undici": "^7.16.0"
}
}
}
Loading