Conversation
nbbeeken
changed the title
nbbeeken
marked this pull request as draft
June 30, 2026 04:57
nbbeeken
changed the title
nbbeeken
changed the title
nbbeeken
changed the title
nbbeeken
marked this pull request as ready for review
July 6, 2026 19:48
| # Clang 22, which the libffi fix in nodejs/node#64222 addresses. That | ||
| # fix is on main but not yet in a v26.x release, so compile a main | ||
| # nightly that contains it to verify VS2026 works. Revert to a plain | ||
| # 26.x release once the fix lands in one. |
There was a problem hiding this comment.
Can we link a jira ticket here that requires to revert it to 26.x?
Contributor
Author
There was a problem hiding this comment.
There was a problem hiding this comment.
We usually put TODO(MONGOSH-3480) to comment block for visibility, not blocking for the merge.
Contributor
Author
There was a problem hiding this comment.
Yea I would've but the CI is a million years long haha. But the release came quick!
alenakhineika
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.