Skip to content

Read embedded title tag instead of always using filename #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trustosas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Read embedded title tag instead of always using filename #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions app/src/main/java/com/brouken/player/PlayerActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,16 +1295,10 @@ public void initializePlayer() {
MediaItem.Builder mediaItemBuilder = new MediaItem.Builder()
.setUri(mPrefs.mediaUri)
.setMimeType(mPrefs.mediaType);
String title;
if (apiTitle != null) {
title = apiTitle;
} else {
title = Utils.getFileName(PlayerActivity.this, mPrefs.mediaUri);
}
if (title != null) {
final MediaMetadata mediaMetadata = new MediaMetadata.Builder()
.setTitle(title)
.setDisplayTitle(title)
.setTitle(apiTitle)
.setDisplayTitle(apiTitle)
.build();
mediaItemBuilder.setMediaMetadata(mediaMetadata);
}
Expand Down Expand Up @@ -1426,6 +1420,15 @@ public void releasePlayer(boolean save) {
}

private class PlayerListener implements Player.Listener {
@Override
public void onMediaMetadataChanged(MediaMetadata mediaMetadata) {
if (mediaMetadata.title != null && mediaMetadata.title.length() > 0) {
titleView.setText(mediaMetadata.title);
} else if (apiTitle == null) {
titleView.setText(Utils.getFileName(PlayerActivity.this, mPrefs.mediaUri));
}
}

@Override
public void onAudioSessionIdChanged(int audioSessionId) {
try {
Expand Down