Skip to content

Delete the sqlsrv database tables widget - #16959

Open
Jako wants to merge 2 commits into
modxcms:3.xfrom
Jako:delete-sqlsrv-grid
Open

Delete the sqlsrv database tables widget#16959
Jako wants to merge 2 commits into
modxcms:3.xfrom
Jako:delete-sqlsrv-grid

Conversation

@Jako

@Jako Jako commented May 29, 2026

Copy link
Copy Markdown
Contributor

What changed and why

Delete the sqlsrv database tables widget. Microsoft SQL Server support was dropped in MODX 3.0 (https://docs.modx.com/3.x/en/getting-started/upgrading-to-3.0/sqlsrv). So it should be safe to remove that widget.

Detected during checking missing and superfluous lexicon entries.

@Jako
Jako requested review from Mark-H and opengeek as code owners May 29, 2026 09:10
@opengeek opengeek added this to the v3.3.0 milestone Jun 11, 2026
@Mark-H

Mark-H commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Would be nice to also add the upgrade script that removes the file on update, i.e. a file like https://github.com/modxcms/revolution/blob/3.x/setup/includes/upgrades/common/3.0.0-cleanup-files.php

@Jako

Jako commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

The upgrade script is added.

@opengeek

Copy link
Copy Markdown
Member

Would be nice to also add the upgrade script that removes the file on update, i.e. a file like https://github.com/modxcms/revolution/blob/3.x/setup/includes/upgrades/common/3.0.0-cleanup-files.php

If we are going to make this a standard requirement for upgrade (this has ONLY ever been done in the upgrade to go from 2.x to 3.x, unless I am unaware of it), then the functions being duplicated in each one of these scripts needs to be incorporated into the setup. I'm happy for us to do that, but I think this is something that needs helper functions for use in the upgrade scripts or some type of automation when not using the code from git. I'll be happy to work out the helper functions and then I can update the script here to use them, unless someone has an objection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants