Fix: Make search results and tree items display in consistent manner - #16958
Open
smg6511 wants to merge 2 commits into
Open
Fix: Make search results and tree items display in consistent manner#16958smg6511 wants to merge 2 commits into
smg6511 wants to merge 2 commits into
Conversation
Adds status classes to items to make search result display consistent with the tree
Code quality fixes
smg6511
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Added status information to search result data and a new method to the front end XTemplate to match how the tree displays the various states of Resources and Elements. Some specific updates of interest:
Design Note
I only touched css minimally here, but will propose a number of style enhancements in a separate PR.
How to test
Test in an environment with many Resources and Elements, having various published/deleted/disabled states and compare the search display to the tree display. The two should match.
Note that some Extras override the tree icon (e.g., Collections, Gallery), but do not override the search one; that disconnect would need to be addressed by the relevant Extras’ maintainers.
Example Screenshots
On the left are a couple clips of my tree; on the right, a few search result examples showing various states. You can spot where specific ones match up.
Related issue(s)/PR(s)
This is a different approach than and supersedes the proposed change in #16659.
Compatibility notes
n/a
Breaking change assessment
None
Test coverage
n/a
Contributors
n/a
AI tool use
n/a