fix(manager): correct OnBeforeManagerPageInit / OnManagerPageInit order - #16937
Open
Ibochkarev wants to merge 1 commit into
Open
fix(manager): correct OnBeforeManagerPageInit / OnManagerPageInit order#16937Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Ibochkarev
marked this pull request as ready for review
March 28, 2026 04:55
Collaborator
|
@opengeek - Was taking a look at this and wanted your stance on the potential BC implications and whether they would cause this change to be blocked anyway. Otherwise it of course makes sense for these events to run in the expected order, although I find the wrapping of them in a new method just to accomodate a test to be unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
modManagerController::render()viainvokeManagerPageInitEvents():OnBeforeManagerPageInitfirst, thenOnManagerPageInit.OnManagerPageInitinvocation frommodManagerRequest::handleRequest()(it ran beforeOnBeforeManagerPageInitinrender()).OnManagerPageInita payload of controller config merged with the current requestactionandnamespace(request values win when set).ManagerPageInitEventsTest).Backward-compatibility note:
OnManagerPageInitnow runs when the controller renders, not at the beginning ofhandleRequest(). Code paths that redirect or exit beforerender()may no longer trigger these two events; listeners that must run earlier should use another system event (e.g.OnHandleRequest).Why is it needed?
Fixes the incorrect ordering described in the issue:
OnBeforeManagerPageInitmust run beforeOnManagerPageInitso plugins can prepare state before the main init event.How to test
phpunit -c _build/test/phpunit.xml --filter ManagerPageInitEventsTestOnBeforeManagerPageInit/OnManagerPageInit; confirm expected order and thataction/namespacein the event payload match the request.Related issue(s)/PR(s)
Resolves #9461