[megatron] Fix router replay CP partition and expert index overflow - #9981
Open
taking-lying-flat wants to merge 1 commit into
Open
[megatron] Fix router replay CP partition and expert index overflow#9981taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Router replay sliced global expert IDs with the default zigzag CP layout even when model inputs used contiguous CP. This could silently assign each local token the experts selected for a different token.
Recorded router indices were also always converted to uint8. Models with more than 256 experts therefore wrapped IDs above 255 before replay.
Compatibility
The CP mode argument defaults to zigzag, and the keyword is only forwarded for contiguous mode. This preserves the existing default path and compatibility with older mcore-bridge versions.
Verification