fix(report): sync HTML reports with console theme - #1646
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evalscope-themepreference before first paintFixes #1639
Root cause
The React console persisted its theme in local storage, while generated HTML reports shipped a separate dark-only stylesheet and
plotly_darklayouts. Since reports render as independent documents, the console theme did not cross that boundary.Design
The report reuses the existing
evalscope-themekey with the same preference order as the console: saved preference, OS preference, then dark. No new API parameter, report-generation option, URL state, or cross-window messaging is introduced.Verification
make lintpassedCompatibility
Existing generated HTML files contain inlined templates and must be regenerated to pick up the new theme support.