Skip to content

feat(web): expose output directory name in Eval/Perf task forms - #1604

Open
Dhru1001 wants to merge 1 commit into
modelscope:mainfrom
Bharatgen-Tech:feat/task-output-dir-ui
Open

feat(web): expose output directory name in Eval/Perf task forms#1604
Dhru1001 wants to merge 1 commit into
modelscope:mainfrom
Bharatgen-Tech:feat/task-output-dir-ui

Conversation

@Dhru1001

Copy link
Copy Markdown
Contributor

Lets users name a run's output directory from the Tasks tab instead of relying on the auto-generated timestamp id. The name becomes the task id (sanitized to filesystem/header-safe characters), which is what the backend already uses to derive work_dir, progress tracking, log lookup, resume, and report listing -- so no backend changes are needed and none of those flows break.

@Dhru1001

Copy link
Copy Markdown
Contributor Author

@Yunnglin

@Yunnglin

Copy link
Copy Markdown
Collaborator

Thanks for adding this. The user need is reasonable, but the implementation should reuse EvalScope’s existing output configuration instead of turning the directory name into task_id.

EvalScope already has TaskConfig.work_dir / no_timestamp for Eval and outputs_dir / name / no_timestamp for Perf. Please pass the setting through the normal config contract and let the service resolve it safely under EVALSCOPE_OUTPUT_DIR.

task_id must remain independently unique because it identifies processes, progress, logs, reports, and stop operations. With the current stable name -> task_id mapping:

  • running the same Perf name twice fails because benchmark_data.db already exists;
  • concurrent same-name tasks overwrite the same process-registry entry and share one output directory.

Please separate the user-facing output/run name from the unique task ID, define collision/resume behavior explicitly, and add coverage for repeated names, concurrent submissions, Perf reruns, Unicode names, and path traversal. If this is only for readability, the simplest solution is a readable name plus a unique suffix.

Lets users name a run's output directory from the Tasks tab instead of
relying on the auto-generated timestamp id. The name becomes the task
id (sanitized to filesystem/header-safe characters), which is what the
backend already uses to derive work_dir, progress tracking, log
lookup, resume, and report listing -- so no backend changes are
needed and none of those flows break.
@Dhru1001
Dhru1001 force-pushed the feat/task-output-dir-ui branch from 4923bae to deef764 Compare August 26, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants