Skip to content

[QA] Raise PHPStan to level 8 - #492

Open
chr-hertel wants to merge 1 commit into
mainfrom
phpstan-level-8
Open

[QA] Raise PHPStan to level 8#492
chr-hertel wants to merge 1 commit into
mainfrom
phpstan-level-8

Conversation

@chr-hertel

@chr-hertel chr-hertel commented Sep 1, 2026

Copy link
Copy Markdown
Member

Raises phpstan.dist.neon from level 6 to 8 and fixes all 330 resulting errors — no new baseline entries, no ignore comments.

Real bugs found along the way:

  • Discoverer::getCompletionProviders() assigned $attributeInstance->provider (always null) in the providerClass branch, so #[CompletionProvider(providerClass: …)] registered nothing.
  • ReflectedElementLoader called spl_object_id() on handlers that can be function-name strings — a TypeError for non-closure ReflectionFunction handlers.
  • ListCompletionProvider declared string[] while the attribute allows ints/floats; values are now normalized, as getCompletions() already assumed.
  • Unchecked false returns from file_get_contents, stream_get_contents, proc_open, preg_split and json_encode.
  • Discoverer::getClassFromFile() returned unloadable type names that then threw out of new ReflectionClass.

Type-model corrections, behaviour-preserving: Page is generic (Page<Tool> …), Tool::$inputSchema no longer claims properties/required are always present, and the capabilities classes serialize \stdClass rather than bare object.

fromArray() parameters in src/Schema widened from narrow array shapes to array<string, mixed>: they parse untrusted wire data and validate at runtime, so the shapes were unenforceable at every call site. 24 pre-existing @phpstan-ignore argument.type comments in tests then became unmatched and were deleted.

make cs, make phpstan and make tests are green.

@chr-hertel
[QA] Raise PHPStan to level 8
dd81334 
Fixes all 330 errors the bump surfaces across src/, tests/ and examples/,
without new baseline entries or ignore comments.
@chr-hertel
chr-hertel requested a balanced review from Copilot September 1, 2026 23:46
Copilot AI reviewed Sep 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The advertised providerClass completion path still throws during attribute construction, and completion argument errors identify the wrong field.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Raises PHPStan from level 6 to 8, correcting type models, unsafe return handling, and several runtime defects across discovery, transport, schema, and registry code.

Changes:

  • Strengthens static types and wire-data parsing.
  • Handles fallible PHP APIs and nullable values safely.
  • Fixes discovery, completion-provider, handler, and schema behavior.
File summaries
File Description
phpstan.dist.neon Enables PHPStan level 8.
src/Client.php Tightens connection and URI validation.
src/Client/Stateless/ToolCatalog.php Handles malformed tool entries safely.
src/Client/Transport/HttpTransport.php Narrows fibers and nullable streams.
src/Client/Transport/StdioTransport.php Validates process and fiber values.
src/Capability/Attribute/CompletionProvider.php Documents provider source types.
src/Capability/Attribute/Schema.php Corrects numeric schema types.
src/Capability/Completion/ListCompletionProvider.php Normalizes scalar completion values.
src/Capability/Discovery/Discoverer.php Fixes discovery and provider resolution.
src/Capability/Discovery/SchemaGenerator.php Improves reflected type handling.
src/Capability/Discovery/SchemaGeneratorInterface.php Reuses the tool schema type.
src/Capability/Discovery/SchemaValidator.php Safely formats validation errors.
src/Capability/Formatter/ResourceResultFormatter.php Handles failed file reads.
src/Capability/Registry.php Adds generic pagination types.
src/Capability/Registry/Loader/ReflectedElementLoader.php Supports named-function handlers safely.
src/Capability/Registry/ReferenceHandler.php Validates callable handlers.
src/Capability/Registry/ResourceTemplateReference.php Handles failed URI splitting.
src/Capability/RegistryInterface.php Adds typed page returns.
src/Schema/ClientCapabilities.php Corrects serialized object types.
src/Schema/Content/AudioContent.php Broadens wire-data input typing.
src/Schema/Content/BlobResourceContents.php Handles stream and file failures.
src/Schema/Content/EmbeddedResource.php Corrects MIME and serialization handling.
src/Schema/Content/ImageContent.php Handles failed image reads.
src/Schema/Content/PromptMessage.php Broadens wire-data input typing.
src/Schema/Content/ResourceLink.php Corrects serialized discriminator typing.
src/Schema/Content/SamplingMessage.php Broadens wire-data input typing.
src/Schema/Content/TextContent.php Broadens wire-data input typing.
src/Schema/Content/TextResourceContents.php Broadens wire-data input typing.
src/Schema/Content/ToolUseContent.php Corrects serialized discriminator typing.
src/Schema/Elicitation/AbstractSchemaDefinition.php Refines serialized base shape.
src/Schema/Elicitation/BooleanSchemaDefinition.php Broadens wire-data input typing.
src/Schema/Elicitation/ElicitationSchema.php Broadens wire-data input typing.
src/Schema/Elicitation/EnumSchemaDefinition.php Broadens wire-data input typing.
src/Schema/Elicitation/MultiSelectEnumSchemaDefinition.php Broadens wire-data input typing.
src/Schema/Elicitation/NumberSchemaDefinition.php Broadens wire-data input typing.
src/Schema/Elicitation/StringSchemaDefinition.php Broadens wire-data input typing.
src/Schema/Elicitation/TitledEnumSchemaDefinition.php Validates and normalizes enum pairs.
src/Schema/Elicitation/TitledMultiSelectEnumSchemaDefinition.php Validates and normalizes enum pairs.
src/Schema/Enum/ProtocolVersion.php Guards empty revision groups.
src/Schema/Extension/Apps/UiToolMeta.php Normalizes visibility as a list.
src/Schema/Icon.php Broadens wire-data input typing.
src/Schema/Implementation.php Safely hydrates icon data.
src/Schema/JsonRpc/Error.php Broadens wire-data input typing.
src/Schema/JsonRpc/Response.php Validates and narrows result members.
src/Schema/Page.php Makes pages generic by item type.
src/Schema/Request/CallToolRequest.php Corrects argument object typing.
src/Schema/Request/CompletionCompleteRequest.php Validates completion arguments.
src/Schema/Request/ElicitRequest.php Omits impossible null parameters.
src/Schema/ResourceDefinition.php Broadens wire-data input typing.
src/Schema/ResourceTemplate.php Broadens wire-data input typing.
src/Schema/Result/ElicitResult.php Broadens wire-data input typing.
src/Schema/Result/InitializeResult.php Broadens wire-data input typing.
src/Schema/Result/ListRootsResult.php Broadens wire-data input typing.
src/Schema/Root.php Broadens wire-data input typing.
src/Schema/ServerCapabilities.php Corrects serialized object types.
src/Schema/Tool.php Refines and normalizes schema types.
src/Schema/ToolChoice.php Validates mixed wire input.
src/Server/Builder.php Supplies default discovery patterns.
src/Server/ClientGateway.php Narrows sampling message conversion.
src/Server/Protocol.php Narrows dispatched event types.
src/Server/Session/Session.php Simplifies nested key traversal.
src/Server/Stateless/StatelessProtocol.php Allows nullable error identifiers.
src/Server/Subscription/PublishingEventDispatcher.php Corrects listener callable typing.
src/Server/Subscription/RegistryChangePublisher.php Corrects listener return typing.
src/Server/Transport/Http/Middleware/OAuthProxyMiddleware.php Makes JSON encoding fail explicitly.
src/Server/Transport/ManagesTransportCallbacks.php Marks the response finder nullable.
src/Server/Transport/StdioTransport.php Validates limits and narrows fibers.
src/Server/Transport/StreamableHttpTransport.php Safely captures and handles fibers.
src/Server/Wire/InboundClassifier.php Narrows nullable version handling.
examples/client/stdio_elicitation.php Handles URL elicitation and null titles.
examples/server/bootstrap.php Selects shutdown behavior by result type.
examples/server/mcp-apps/WeatherApp.php Handles template read failures.
examples/server/oauth-microsoft/McpElements.php Handles failed timestamp parsing.
tests/Conformance/Elements.php Uses throwing JSON encoding.
tests/Inspector/Http/HttpSchemaShowcaseTest.php Handles failed regex normalization.
tests/Inspector/InspectorSnapshotTestCase.php Asserts snapshot reads succeed.
tests/Inspector/Stdio/StdioCustomDependenciesTest.php Handles failed regex normalization.
tests/Integration/HandshakeTest.php Narrows nullable server information.
tests/Integration/SamplingTest.php Narrows sampling request data.
tests/Integration/SamplingToolsTest.php Narrows tool-sampling requests.
tests/Unit/Capability/Discovery/DiscoveryTest.php Adds static-analysis assertions.
tests/Unit/Capability/Discovery/DocBlockParserTest.php Narrows nullable descriptions.
tests/Unit/Capability/Discovery/SchemaValidatorTest.php Uses throwing JSON encoding.
tests/Unit/Capability/Formatter/PromptResultFormatterTest.php Narrows formatted resource content.
tests/Unit/Capability/Registry/Loader/ChainLoaderTest.php Narrows closure handlers.
tests/Unit/Capability/Registry/Loader/DiscoveryLoaderTest.php Narrows closure handlers.
tests/Unit/Capability/Registry/Loader/ExplicitElementLoaderTest.php Narrows resource references.
tests/Unit/Capability/Registry/Loader/ReflectedElementLoaderResourceTitleTest.php Narrows resource references.
tests/Unit/Capability/RegistryTest.php Corrects mock and closure types.
tests/Unit/Client/Transport/StdioTransportTest.php Asserts stream creation succeeds.
tests/Unit/Schema/ClientCapabilitiesTest.php Narrows serialized capabilities.
tests/Unit/Schema/Content/ImageContentTest.php Uses safe serialization assertions.
tests/Unit/Schema/Content/PromptMessageTest.php Uses throwing JSON encoding.
tests/Unit/Schema/Content/ResourceLinkTest.php Narrows optional serialized fields.
tests/Unit/Schema/Content/SamplingMessageTest.php Narrows content blocks and JSON.
tests/Unit/Schema/Content/ToolResultContentTest.php Uses throwing JSON encoding.
tests/Unit/Schema/Content/ToolUseContentTest.php Uses throwing JSON encoding.
tests/Unit/Schema/Elicitation/BooleanSchemaDefinitionTest.php Removes obsolete PHPStan suppression.
tests/Unit/Schema/Elicitation/ElicitationSchemaTest.php Updates mixed-data assertions.
tests/Unit/Schema/Elicitation/EnumSchemaDefinitionTest.php Removes obsolete PHPStan suppressions.
tests/Unit/Schema/Elicitation/MultiSelectEnumSchemaDefinitionTest.php Removes obsolete PHPStan suppressions.
tests/Unit/Schema/Elicitation/NumberSchemaDefinitionTest.php Removes obsolete PHPStan suppression.
tests/Unit/Schema/Elicitation/StringSchemaDefinitionTest.php Removes obsolete PHPStan suppression.
tests/Unit/Schema/Elicitation/TitledEnumSchemaDefinitionTest.php Removes obsolete PHPStan suppressions.
tests/Unit/Schema/Elicitation/TitledMultiSelectEnumSchemaDefinitionTest.php Removes obsolete PHPStan suppressions.
tests/Unit/Schema/Extension/Apps/McpAppsTest.php Narrows optional serialized metadata.
tests/Unit/Schema/Extension/CapabilitiesExtensionsTest.php Narrows extension objects.
tests/Unit/Schema/IconTest.php Narrows nullable icon fields.
tests/Unit/Schema/ImplementationTest.php Removes obsolete PHPStan suppressions.
tests/Unit/Schema/NonObjectOutputSchemaTest.php Updates optional schema assertions.
tests/Unit/Schema/Request/CreateSamplingMessageRequestTest.php Narrows request payload fields.
tests/Unit/Schema/ResourceDefinitionTest.php Narrows optional title assertions.
tests/Unit/Schema/ResourceTemplateTest.php Narrows optional title assertions.
tests/Unit/Schema/Result/CallToolResultTest.php Uses throwing JSON encoding.
tests/Unit/Schema/Result/CreateSamplingMessageResultTest.php Narrows content and serialization.
tests/Unit/Schema/Result/ElicitResultTest.php Removes obsolete PHPStan suppression.
tests/Unit/Schema/Result/ListRootsResultTest.php Updates malformed-data and JSON tests.
tests/Unit/Schema/ServerCapabilitiesTest.php Narrows serialized capability objects.
tests/Unit/Schema/ToolChoiceTest.php Removes obsolete PHPStan suppressions.
tests/Unit/Schema/ToolTest.php Narrows optional schema members.
tests/Unit/Server/BuilderTest.php Narrows nullable configuration.
tests/Unit/Server/Handler/Request/CallToolHandlerTest.php Narrows tool result types.
tests/Unit/Server/Stateless/StatelessProtocolTest.php Narrows streams and frame data.
tests/Unit/Server/Transport/Http/Middleware/ClientRegistrationMiddlewareTest.php Uses throwing JSON encoding.
tests/Unit/Server/Transport/Http/OAuth/JwtTokenValidatorTest.php Guards response sequence access.
tests/Unit/Server/Transport/StdioTransportTest.php Asserts stream creation succeeds.
Review details
  • Files reviewed: 126/126 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Capability/Attribute/CompletionProvider.php
* @param class-string<ProviderInterface>|ProviderInterface|null $provider if a class-string, it will be resolved
* from the container at the point of use
* @param ?array<int, int|float|string> $values a list of values to use for completion
* @param class-string<ProviderInterface>|null $providerClass a provider class to resolve from the container at the point of use
Comment thread src/Schema/Request/CompletionCompleteRequest.php
Comment on lines +57 to +60
return new self($ref, [
'name' => self::refString($params['argument'], 'name'),
'value' => self::refString($params['argument'], 'value'),
]);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner
@CodeWithKyrian CodeWithKyrian Awaiting requested review from CodeWithKyrian CodeWithKyrian is a code owner
@soyuka soyuka Awaiting requested review from soyuka soyuka is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chr-hertel