-
-
Notifications
You must be signed in to change notification settings - Fork 321
useDeepEquality option is not being passed to the generated code
#1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ben-milanko
wants to merge
14
commits into
mobxjs:main
Choose a base branch
from
Railway-Engineering-Solutions:fix/deep-equality-observable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e258ebd
Implement observeKey extension on ObservableMap
ben-milanko c1c5fd3
Revert "Implement observeKey extension on ObservableMap"
ben-milanko 29ad03c
Fix useDeepEquality not being passed to observables
ben-milanko 6e552cc
Update change log and bump version
ben-milanko 1abf734
Merge branch 'mobxjs:main' into main
ben-milanko 465eed5
Merge branch 'main' into fix/deep-equality-observable
ben-milanko 4299dcf
Update observable template for late field setter
ben-milanko 00b6e2b
Merge branch 'mobxjs:main' into main
ben-milanko 05dafc4
Merge branch 'main' into fix/deep-equality-observable
ben-milanko 2aab235
Fix lint errors and run build
ben-milanko 6d0923b
Update valid output
ben-milanko 298d2ce
Update test formatting
ben-milanko 2031f57
Merge upstream/main - support analyzer v10-v12
ben-milanko 884b6cc
Merge branch 'main' into fix/deep-equality-observable
ben-milanko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| // Generated via set_version.dart. !!!DO NOT MODIFY BY HAND!!! | ||
|
|
||
| /// The current version as per `pubspec.yaml`. | ||
| const version = '2.7.4'; | ||
| const version = '2.7.5'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.