feat(#12): kill and terminate buttons for spawned processes - #36
Merged
Conversation
added 2 commits
August 12, 2026 16:20
Child rows (parent_id != 0) get the same hover-revealed action overlay as session rows, with two buttons: SIGTERM to end the process gracefully and SIGKILL when it won't go quietly. Row teardown is already handled by poll_children noticing the PID is gone. Closes #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12.
Child rows in the sidebar (
parent_id != 0) now get the same hover-revealed action overlay that session rows have, carrying two buttons:window-close-symbolic- Terminate process (SIGTERM)edit-delete-symbolic- Force kill process (SIGKILL), for when it will not go quietlyThe overlay construction in
make_rowmoved out of theif (!s->parent_id)branch so both row kinds share it.apply_row_visibilitypushes the label margin in by 72 px on child rows (2 icons) instead of 136 px (4 icons). Robot rows have no label vbox, so the name label itself is registered asgattn-row-labels.No teardown code was needed: the existing
poll_children->on_child_exitedpath removes the row once the PID is gone.Also updated
README.md,docs/a11y-testing.md(tooltip list for both row kinds), and marked theFEATURES.orgentry DONE.Also adds a root
.gitignorefor the nixresultsymlink and.cache/.