Change default search_results behavior to grouped by collection - #106
Open
rshiggin wants to merge 1 commit into
Open
Change default search_results behavior to grouped by collection#106rshiggin wants to merge 1 commit into
rshiggin wants to merge 1 commit into
Conversation
rshiggin
marked this pull request as ready for review
September 11, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes essentially add
&group=trueto thesearch_resultsURL query string. Note that the change in the helper file makes "All results" explicit. The button has to explicitly say group=false.I'm a little confused, though, when comparing to
prod. I can't tell when&group=trueis added to prod URL and when it's not. Do we need to account for special circumstances when the default is "All results" vs "Grouped by collection"?cc @ssciolla @respinos