Skip to content

added conditon to allow only add admin to access add club #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shanky2003g wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added conditon to allow only add admin to access add club #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions base/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,17 @@ def user_delete(request, user_id):

@login_required(login_url='login')
def club_add(request):
# Adding a new club
form = ClubForm()
if request.method == 'POST':
form = ClubForm(request.POST, request.FILES)
if form.is_valid():
form.save()
messages.success(request, 'Club added successfully!')
return redirect('/')
# Adding a new club
if can_user_access(request.user.id, 'club_add'): # preventing convenor and member to access add clubs

@mittal-parth mittal-parth Mar 6, 2024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if can_user_access(request.user.id, 'club_add'): # preventing convenor and member to access add clubs
if can_user_access(request.user.id, 'club_add'):

We need not hardcode who has access in the comments.

form = ClubForm()
if request.method == 'POST':
form = ClubForm(request.POST, request.FILES)
if form.is_valid():
form.save()
messages.success(request, 'Club added successfully!')
return redirect('/')
else:
return redirect('error_page')

@mittal-parth mittal-parth Mar 6, 2024

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return redirect('error_page')
return render(request, 'error_page.html')

context = {'form': form}
return render(request, 'club_add.html', context)

Expand Down