Add janus-room-allow-ws-participants for AudioBridge WS media - #5
Closed
mirkobrankovic82 wants to merge 1 commit into
Closed
Add janus-room-allow-ws-participants for AudioBridge WS media#5mirkobrankovic82 wants to merge 1 commit into
mirkobrankovic82 wants to merge 1 commit into
Conversation
… create Rooms created by mod_janus must set allow_ws_participants at create time so BFF can attach a WebSocket RTP leg to an existing call via rtpws. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
janus-room-allow-ws-participants(per-call, dialplan-controlled).allow_ws_participants: truein the Janus AudioBridgecreaterequest.POST /v2/webrtc/ws-media-sessioncan attach a WebSocket RTP leg to an existing call (room already created by mod_janus).Context
Janus only allows
media: websocketjoins when the room was created withallow_ws_participants=true. The flag cannot be changed viaeditafter creation.Pairs with:
janus-room-allow-ws-participants=trueon Janus originatesTest plan
{janus-room-allow-ws-participants=true}janus/...allow_ws_participants: truePOST /v2/webrtc/ws-media-sessionfor sameroomIdreturnswsMediaUrl(not error 489)false)Made with Cursor