fix(s3): apply the ACL and the source conditions a copy carries - #1482
fix(s3): apply the ACL and the source conditions a copy carries#1482gaul wants to merge 1 commit into
Conversation
CopyObject dropped x-amz-acl, so a copy addressed public-read landed private and stayed that way -- the caller had no way to tell except by reading the ACL back. It now permissions the destination as a put does, and refuses an unknown value rather than ignoring it. A copy without one leaves the destination private rather than inheriting whatever the key it replaced carried. UploadPartCopy ignored all four x-amz-copy-source-if-* headers and copied the range regardless, which is the hazard a conditional read exists to prevent: the part is assembled from a source that has since changed. CopyObject already judged them correctly, so the block moves into a helper both operations ask -- one place to be right, and no chance of the two drifting apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Docker image for this PR has been published: |
|
@gaul You are inferrinf these from AI. To avoid the back-and-forth that happened in 1451, please first raise an issue with the repro steps showing where Ministack drifted from AWS. Once that’s identified, we can fix it directly. I'm closing these ones |
|
I filed the requested issues. All of my PRs were sourced from s3-tests running against S3Proxy running against ministack. I apologize for the noise of 1451 but generally these PRs are grounded in a reality, albeit Ceph's reality. It would be good to include s3-tests in ministack's CI now that most issues are fixed. I have already included ministack alongside localstack in S3Proxy's CI with a handful of s3-tests exclusions. |
|
Docker image for this PR has been published: |
2 participants
CopyObject dropped x-amz-acl, so a copy addressed public-read landed private and stayed that way -- the caller had no way to tell except by reading the ACL back. It now permissions the destination as a put does, and refuses an unknown value rather than ignoring it. A copy without one leaves the destination private rather than inheriting whatever the key it replaced carried.
UploadPartCopy ignored all four x-amz-copy-source-if-* headers and copied the range regardless, which is the hazard a conditional read exists to prevent: the part is assembled from a source that has since changed. CopyObject already judged them correctly, so the block moves into a helper both operations ask -- one place to be right, and no chance of the two drifting apart.