Refactor stratum server leak handling - #3876
Open
syntaxjak wants to merge 13 commits into
Open
Conversation
4 tasks
|
Heads-up: #3889 also targets #3867 with the same structural approach ( That PR additionally adds idle timeout, max workers, and bounded write queues for the half-open / reconnect-storm failure mode. Worth coordinating so the two don’t land overlapping refactors without combining the resource bounds. |
wiesche89
self-requested a review
July 22, 2026 17:16
wiesche89
reviewed
Jul 22, 2026
wiesche89
left a comment
Contributor
There was a problem hiding this comment.
I tested this with a miner and additional connection tests. The cleanup works for normal disconnects, but it does not fully solve the reported connection leak yet. I’ve left a few comments on the remaining cases.
https://github.com/GetGrin/grim/issues/19
syntaxjak
force-pushed
the
fix-stratum-leaks
branch
from
July 25, 2026 16:57
3d54a2b to
7fb84a5
Compare
wiesche89
force-pushed
the
fix-stratum-leaks
branch
from
July 26, 2026 13:32
21a680f to
481fd9e
Compare
wiesche89
force-pushed
the
fix-stratum-leaks
branch
from
July 26, 2026 18:52
ded14f2 to
b7f96c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue: #3867