chore: remove unused jsdom dependency - #1190
Closed
oduameh wants to merge 1 commit into
Closed
Conversation
jsdom is declared in dependencies but nothing in the repo imports it: no source file, script, plugin, or config references it, and no other package in the lockfile depends on it. Removing it drops 387 lines of transitive dependencies and stops recurring bot bump PRs for a package we do not use (see #1174).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsdom sits in
dependenciesbut nothing in the repo uses it: no source file, script, plugin, or config imports it, and after removal yarn resolves cleanly, confirming no other package depends on it.Removing it:
yarn.lockTesting
yarn install --mode=update-lockfileresolves with no missing peer/dependency warnings related to jsdom