Add windows-strings crate - #3125
Merged
Merged
Conversation
Collaborator
Author
|
Looks like the readme tests were accidentally disabled - cf9b35b turns them back on. |
Collaborator
Author
|
This whole non-Windows appeasement thing is getting old. It's making it too difficult to support Windows, which is the whole point of this project. 🤪 Anyway, the latest version retains basic Linux compatibility for |
Rafael Rivera (riverar)
approved these changes
Jun 25, 2024
Chris Denton (ChrisDenton)
approved these changes
Jun 25, 2024
Chris Denton (ChrisDenton)
left a comment
Chris Denton (ChrisDenton)
left a comment
Collaborator
There was a problem hiding this comment.
I think this is a good approach, not just for windows- crates but also for the windows ecosystem in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update pulls out the Windows string types from the
windows-corecrate and makes them available directly without a dependency on thewindowsorwindows-corecrates. This will help to make these string types more accessible to library crates such aswindows-registry(#3121).These types are still included in the
windows-coreandwindowscrates as a dependency so it should not affect existing code too much.