Add artifact merge engines and Kind metadata flow (RFC 018 phase 1) by Evangelink · Pull Request #9805 · microsoft/testfx

Evangelink · 2026-07-09T22:09:28Z

Summary

Implements the first testfx-side pieces of RFC 018 — Artifact post-processing for dotnet test (MTP). Two independent, self-contained foundations that every later phase (dispatcher tool, SDK election) reuses. No SDK dependency; the SDK orchestration lands separately once this merges.

1. Report merge engines (pure, invocation-agnostic — no I/O in the core)

Validated the RFC's "collect same-kind inputs → re-aggregate → emit one" shape across both data models:

Engine	Format	Merge unit	Re-aggregation
`TrxReportEngine.Merge` / `MergeToFileAsync`	XML	`Results`/`TestDefinitions`/`TestEntries`	counters summed, `Times` earliest/latest, `TestLists` deduped by id, outcome `Failed` if any input failed
`JUnitReportMerger`	XML	`<testsuite>`	counters derived by summing per-suite (correct even when root aggregates are missing); supports bare `<testsuite>` roots
`CtrfReportMerger`	JSON (`JsonNode`)	`results.tests[]`	`summary` derived from the merged `tests[]` so `summary.tests` always matches the array; `start`/`stop` min/max

HTML is intentionally not file-merged (it's a rendered template with an embedded JSON blob) — this validates the design's opt-in / return-null semantics rather than breaking it.

2. `Kind` metadata flow (producer → IPC wire)

So the dotnet test orchestrator can group artifacts by format without inspecting file contents:

SessionFileArtifact gains an optional kind (experimental-gated, [TPEXP]); the shipped 4-arg constructor is preserved for binary compatibility.
IPC: FileArtifactMessage.Kind + FileArtifactMessageFieldsId.Kind = 7 + serializer read/write/field-count (forward/backward compatible — old readers skip the unknown field).
DotnetTestDataConsumer propagates Kind onto the wire message.
Report producers tag their kind: TRX microsoft.testing.trx, JUnit microsoft.testing.junit, CTRF microsoft.testing.ctrf, HTML microsoft.testing.html.

Tests

Unit tests for all three merge engines (null/empty inputs, counter summing, outcome, dedup, timestamps, bare-root/missing-aggregate robustness, summary-missing).
IPC protocol round-trip tests assert Kind survives the pipe.
Full repo builds clean (only the unrelated WasiPlayground sample fails on a missing workload); Platform IPC/protocol, contract-package, and Extensions unit tests all green.

Not in this PR (future phases, per the RFC)

IArtifactPostProcessor typed contract wrapping the engines.
Handshake advertisement of post-processor kinds.
Dispatcher ITool + tool-host-over-pipe composition.
User tools (merge-trx, …) and the dotnet/sdk orchestration.

cc @Evangelink

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

Implements the first testfx-side pieces of RFC 018 (artifact post-processing for dotnet test / MTP): - Report merge engines (pure, invocation-agnostic, no I/O in the core): - TrxReportEngine.Merge / MergeToFileAsync (XML-level TRX merge). - JUnitReportMerger (unions <testsuite>, counters derived per-suite). - CtrfReportMerger (JSON merge; summary derived from merged tests[]). - Kind metadata flow so the dotnet/sdk orchestrator can group artifacts by format: SessionFileArtifact gains an optional kind (experimental), the FileArtifactMessage IPC record + serializer carry Kind (field id 7), the dotnet-test consumer propagates it, and report producers tag their kind (trx/junit/ctrf/html). Unit tests cover all three merge engines and the IPC round-trip. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Adds report-merging foundations and propagates artifact format metadata through MTP’s artifact and IPC layers.

Changes:

Adds TRX, JUnit, and CTRF merge engines with unit tests.
Adds experimental SessionFileArtifact.Kind metadata and IPC serialization.
Tags TRX, JUnit, CTRF, and HTML report artifacts by format.

Show a summary per file

File	Description
`test/UnitTests/Microsoft.Testing.Platform.UnitTests/IPC/ProtocolTests.cs`	Covers IPC kind serialization.
`test/UnitTests/Microsoft.Testing.Platform.UnitTests/IPC/ProtocolEdgeCaseTests.cs`	Tests nullable kind round trips.
`test/UnitTests/Microsoft.Testing.Platform.DotnetTestProtocolContract.UnitTests/DotnetTestProtocolSerializerTests.cs`	Verifies protocol-contract serialization.
`test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxReportEngineMergeTests.cs`	Tests TRX merging.
`test/UnitTests/Microsoft.Testing.Extensions.UnitTests/JUnitReportMergerTests.cs`	Tests JUnit merging.
`test/UnitTests/Microsoft.Testing.Extensions.UnitTests/CtrfReportMergerTests.cs`	Tests CTRF merging.
`src/Platform/SharedExtensionHelpers/ReportGeneratorBase.cs`	Publishes report artifact kinds.
`src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Serializers/FileArtifactMessagesSerializer.cs`	Serializes the new kind field.
`src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/ObjectFieldIds.cs`	Assigns IPC field ID 7.
`src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Models/FileArtifactMessages.cs`	Adds kind to the wire model.
`src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/DotnetTestDataConsumer.cs`	Propagates session artifact kinds.
`src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt`	Tracks the experimental public API.
`src/Platform/Microsoft.Testing.Platform/Messages/FileArtifacts.cs`	Adds the kind-aware constructor and property.
`src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt`	Tracks IPC internal API changes.
`src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Merge.cs`	Implements TRX merging.
`src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxDataConsumer.cs`	Tags in-process TRX artifacts.
`src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txt`	Tracks TRX internal APIs.
`src/Platform/Microsoft.Testing.Extensions.Retry/InternalAPI/InternalAPI.Unshipped.txt`	Tracks linked IPC field API.
`src/Platform/Microsoft.Testing.Extensions.MSBuild/InternalAPI.Unshipped.txt`	Tracks linked IPC field API.
`src/Platform/Microsoft.Testing.Extensions.JUnitReport/JUnitReportMerger.cs`	Implements JUnit merging.
`src/Platform/Microsoft.Testing.Extensions.JUnitReport/JUnitReportGenerator.cs`	Tags JUnit artifacts.
`src/Platform/Microsoft.Testing.Extensions.JUnitReport/InternalAPI/InternalAPI.Unshipped.txt`	Tracks JUnit internal APIs.
`src/Platform/Microsoft.Testing.Extensions.HtmlReport/InternalAPI/InternalAPI.Unshipped.txt`	Tracks shared generator API.
`src/Platform/Microsoft.Testing.Extensions.HtmlReport/HtmlReportGenerator.cs`	Tags HTML artifacts.
`src/Platform/Microsoft.Testing.Extensions.HangDump/InternalAPI/InternalAPI.Unshipped.txt`	Tracks linked IPC field API.
`src/Platform/Microsoft.Testing.Extensions.CtrfReport/InternalAPI/InternalAPI.Unshipped.txt`	Tracks CTRF internal APIs.
`src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportMerger.cs`	Implements CTRF merging.
`src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportGenerator.cs`	Tags CTRF artifacts.

Review details

Files reviewed: 28/28 changed files
Comments generated: 4
Review effort level: Medium

…ure-broccoli # Conflicts: # src/Platform/Microsoft.Testing.Extensions.CtrfReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.HangDump/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.HtmlReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.JUnitReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt

- Carry microsoft.testing.trx through the out-of-process TRX path by adding an (experimental) Kind to FileArtifact and propagating it in DotnetTestDataConsumer and TrxProcessLifetimeHandler; centralize the kind in TrxReportEngine.TrxArtifactKind. - Deduplicate <UnitTest> definitions by id when merging TRX (ids are deterministic from the test UID and the schema forbids duplicates). - Preserve <RunInfos> (crash/exit diagnostics) and <CollectorDataEntries> from every input's <ResultSummary> instead of discarding them; omit them when empty. - Correct the inaccurate 'attachment paths are absolute' remark and relocate each input's attachment deployment tree into the merged deployment root in MergeToFileAsync (best-effort, never fails the merge). - Add unit tests for dedup and diagnostics preservation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 30/30 changed files
Comments generated: 11
Review effort level: Medium

…ure-broccoli # Conflicts: # src/Platform/Microsoft.Testing.Extensions.CtrfReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.HangDump/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.HtmlReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.JUnitReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.MSBuild/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.Retry/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txt # src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt

Copilot

Review details

Files reviewed: 30/30 changed files
Comments generated: 3
Review effort level: Medium

- Skip relocation when the merged 'In' root overlaps the source 'In' root (output written beside the input with a matching runName), preventing the copy from recursing into its own destination; the original hrefs already resolve there. - Skip file reparse points (symlinks) before File.Copy so a link inside the confined tree can't pull in content from outside it. - Overwrite copied attachment files so a reused output directory can't leave stale bytes behind while the merged XML references the fresh per-input destination. - Add a unit test for the overlapping-root skip case. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 30/30 changed files
Comments generated: 1
Review effort level: Medium

Regenerated via UpdateXlf. The last localized check-in added translations for 'GlobalTestFixtureShouldBeValidClassLayout' (fr) and 'SlowTestStillRunning' (ru) that XliffTasks rejects (placeholder mismatch), breaking the build with "xlf is out-of-date with resx". UpdateXlf resets those two units to state="new" so the build passes; they will be re-translated on the next localization pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4350f662-0e5d-4e05-b156-1ef619da3b9e

Copilot

Review details

Files reviewed: 32/32 changed files
Comments generated: 3
Review effort level: Low

Copilot

Review details

Files reviewed: 31/31 changed files
Comments generated: 5
Review effort level: Medium

…ias check (review) - TRX Merge now carries run-level <ResultSummary>/<Output> across (StdOut/StdErr/ DebugTrace concatenated, TextMessages/Message unioned), emitted in schema order right after <Counters>, so VSTest's run-level skipped/informational messages are no longer silently dropped. - MergeToFileAsync rejects an empty input list before any filesystem work (output directory creation / attachment relocation), so an invalid call no longer mutates the disk before Merge throws. Applied to TRX/JUnit/CTRF. - Output-alias check is now filesystem-aware: it compares canonicalized paths with a cached case-sensitivity probe (case-sensitive on case-sensitive volumes, insensitive otherwise), so on Linux a legitimate separate output like 'A.trx' is no longer rejected as aliasing input 'a.trx', while Windows/macOS case aliases are still caught. Applied to TRX/JUnit/CTRF. Tests: run-level Output merge + schema order; empty-input rejection without touching the filesystem (all three mergers). 74 merge tests pass; full solution build clean. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 31/31 changed files
Comments generated: 3
Review effort level: Medium

…view) The alias-equality check derived its case sensitivity from a one-time probe in Path.GetTempPath(), but case sensitivity can differ per volume and (on Windows) per directory. Replace the cached temp probe with a per-call probe of the OUTPUT's own location (nearest existing ancestor) in all three mergers. An alias can only occur when input and output share a directory, so that shared location's sensitivity is the correct one — a different-directory input never compares equal. Falls back to case-insensitive (rejects more, never less) if the probe fails. This closes the gap where 'A.trx' could alias input 'a.trx' on a case-insensitive output volume while the temp-based probe said Ordinal, letting ReplaceFile delete the input. Applied to TRX/JUnit/CTRF. 74 merge tests pass; full solution build clean. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 31/31 changed files
Comments generated: 3
Review effort level: Medium

…er (review) The read-only-input alias check (canonicalization, per-output-directory case-sensitivity probe, netstandard reparse-ancestor fail-closed) and the atomic temporary-sibling write/ replace were duplicated in the TRX, JUnit and CTRF mergers. Because this is security- and data-loss-sensitive, extract it into a single shared SharedExtensionHelpers/ MergeOutputFileHelper.cs (linked into all three, namespace Microsoft.Testing.Extensions), exposing EnsureOutputDoesNotAliasInput and WriteViaTemporarySiblingAsync so the logic can no longer diverge across formats. Each merger now delegates to it; the per-format writer (XDocument stream vs string) is passed as a callback. Registered the shared internal type/ methods in each project's InternalAPI.Unshipped.txt. No behavior change. 74 merge tests pass; full solution build clean (0 warnings). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 35/35 changed files
Comments generated: 4
Review effort level: Medium

…ments CI (macOS): GetCanonicalPath now re-resolves ancestor symlinks after every link hop, so a link target whose prefix is itself a symlink (macOS /var -> /private/var) canonicalizes consistently and the read-only-input alias check no longer misses a symlinked-parent output. Fixes the 3 WhenOutputAliasesInputViaSymlinkedParent merge tests that failed on macOS. Review comments addressed: - MergeOutputFileHelper.ReplaceFile: atomic File.Move(overwrite:true) on netcore so an interruption can never leave the previous report missing; delete-then-move retained only on .NET Framework (no overwrite overload). - TRX relocation: deployment root is now unique per run (run id suffix), so relocation always writes a fresh tree and can never corrupt a previously committed report's attachments if a later merge fails. - TRX Times: earliest creation/queuing/start tracked independently and omitted when no input supplies them, instead of fabricating all three from the earliest start. - CTRF reportId: derived only from accepted CTRF payloads, so an ignored non-CTRF input no longer changes the merged report identity. Adds regression tests for each and updates deployment-root-coupled TRX tests to read the emitted runDeploymentRoot instead of assuming a literal name. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 34f1a49b-b1e0-4f38-b8a1-3870dd0842d2

Copilot

Review details

Files reviewed: 35/35 changed files
Comments generated: 1
Review effort level: Medium

github-actions · 2026-07-16T12:11:35Z

🧪 Test quality grade — PR #9805

Grade	Test	Notes
B (80–89)	new `CtrfReportMergerTests. Merge_ ReportIdIsUnaffectedByIgnoredNonCtrfInput`	Clear scenario and deterministic inputs; equality assertion on both IDs plus a non-null guard make this near-perfect — no issues found, A could be reached by noting the comment rationale inline.
B (80–89)	mod `TrxReportEngineMergeTests. MergeToFileAsync_ WhenInputLivesUnderMergedRoot_ PreservesOriginalReportAndAttachment`	Presence-only assertions (File.Exists) confirm files survive, but adding a content check (File.ReadAllText) would close the preservation guarantee fully.
B (80–89)	mod `TrxReportEngineMergeTests. MergeToFileAsync_ WhenRunNameEscapesOutputDirectory_ UsesConfinedDeploymentRoot`	Security assertions (StartsWith, no-separator, confinement scan) are well-chosen; ~38-line body with a directory scan could be split into a confinement test and a content-integrity test.
B (80–89)	mod `TrxReportEngineMergeTests. MergeToFileAsync_ RepeatedIntoSameNestedLayout_ IsBoundedAndNonDestructive`	Loop + copy-count + href-resolution are all meaningful; the for-loop is idiomatic here, but extracting the loop limit (4) into a named constant would clarify intent.
B (80–89)	mod `TrxReportEngineMergeTests. MergeToFileAsync_ RelocatesPerTestResultFilesByPrefixingResultDirectory`	Four meaningful assertions covering path rewriting and file content; ~50-line body with manual XML construction — consider extracting a BuildResultFilesReport helper to compress the arrange phase.
A (90–100)	new `CtrfReportMergerTests. Merge_ ReportIdIsUnaffectedByIgnoredNonCtrfInput`	Inline comment explains non-CTRF input semantics; equality on both IDs plus IsNotNull guard — no issues found.
A (90–100)	new `TrxReportEngineMergeTests. Merge_ TimesOmitAttributesNoInputSupplies`	Null-absence and equality assertions together cover both the omission and the surviving fields — no issues found.
A (90–100)	new `TrxReportEngineMergeTests. Merge_ TimesTrackEarliestCreationQueuingStartIndependently`	All four time attributes verified independently with inputs deliberately split across two reports — no issues found.
A (90–100)	new `TrxReportEngineMergeTests. MergeToFileAsync_ SecondMergeIntoSameOutput_ DoesNotCorruptPriorReportsAttachments`	Two-merge scenario with distinct-root assertion and byte-level content verification — no issues found.
A (90–100)	mod `TrxReportEngineMergeTests. MergeToFileAsync_ IsolatesCollidingAttachmentsPerInputAndRewritesHrefs`	Now reads mergedRoot from the document rather than assuming runName; content + href assertions are thorough — no issues found.
A (90–100)	mod `TrxReportEngineMergeTests. MergeToFileAsync_ WhenRunNameMatchesInputDeploymentRoot_ UsesUniqueRootAndRelocates`	AreNotEqual uniqueness check, original-preservation check, and content-verified href resolution — no issues found.
A (90–100)	mod `TrxReportEngineMergeTests. MergeToFileAsync_ WhenSourceNestedUnderMergedRoot_ RelocatesAndKeepsHrefsValid`	Reads mergedRoot dynamically and validates href resolution end-to-end with content check — no issues found.

_{This advisory comment was generated automatically. Grades are heuristic

and informational — they do not block merging. Re-run with

/grade-tests.}

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 71.5 AIC · ⌖ 5.33 AIC · ⊞ 8.9K · [◷]( · ◷)

Copilot AI review requested due to automatic review settings July 9, 2026 22:09

Copilot started reviewing on behalf of Evangelink July 9, 2026 22:10 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Evangelink marked this pull request as ready for review July 13, 2026 14:43

Evangelink and others added 2 commits July 13, 2026 16:50

Copilot AI review requested due to automatic review settings July 13, 2026 15:04

Copilot started reviewing on behalf of Evangelink July 13, 2026 15:07 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

github-code-quality Bot found potential problems Jul 13, 2026

View reviewed changes

Comment thread test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxReportEngineMergeTests.cs Fixed

This comment has been minimized.

Sign in to view

Evangelink added the state/needs-review Awaiting review from the team. label Jul 13, 2026

0101 approved these changes Jul 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 13, 2026 19:50

Copilot started reviewing on behalf of Evangelink July 13, 2026 19:53 View session

0101 approved these changes Jul 13, 2026

View reviewed changes

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 13, 2026 20:06

0101 approved these changes Jul 13, 2026

View reviewed changes

Evangelink enabled auto-merge (squash) July 13, 2026 20:08

Copilot started reviewing on behalf of Evangelink July 13, 2026 20:11 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Merge.cs Outdated

This comment has been minimized.

Sign in to view

Copilot AI review requested due to automatic review settings July 14, 2026 08:01

Copilot started reviewing on behalf of Evangelink July 14, 2026 08:03 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread test/UnitTests/Microsoft.Testing.Platform.UnitTests/IPC/ProtocolTests.cs

Comment thread ...Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.ru.xlf

Comment thread src/Analyzers/MSTest.Analyzers/xlf/Resources.fr.xlf Outdated

Copilot started reviewing on behalf of Evangelink July 15, 2026 19:25 View session

This comment has been minimized.

Sign in to view

0101 approved these changes Jul 15, 2026

View reviewed changes

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 16, 2026 07:49

Copilot started reviewing on behalf of Evangelink July 16, 2026 07:49 View session

0101 approved these changes Jul 16, 2026

View reviewed changes

Copilot AI reviewed Jul 16, 2026

View reviewed changes

Comment thread src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Merge.cs Outdated

Comment thread src/Platform/Microsoft.Testing.Extensions.JUnitReport/JUnitReportMerger.cs Outdated

Comment thread src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportMerger.cs Outdated

This comment has been minimized.

Sign in to view

Copilot AI review requested due to automatic review settings July 16, 2026 08:10

Copilot started reviewing on behalf of Evangelink July 16, 2026 08:11 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

Comment thread src/Platform/Microsoft.Testing.Extensions.JUnitReport/JUnitReportMerger.cs Outdated

Comment thread src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportMerger.cs Outdated

Comment thread src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.Merge.cs Outdated

0101 approved these changes Jul 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 16, 2026 08:40

Copilot started reviewing on behalf of Evangelink July 16, 2026 08:40 View session

This comment has been minimized.

Sign in to view

0101 approved these changes Jul 16, 2026

View reviewed changes

Copilot AI reviewed Jul 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 16, 2026 12:00

Copilot started reviewing on behalf of Evangelink July 16, 2026 12:01 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

Comment thread src/Platform/SharedExtensionHelpers/MergeOutputFileHelper.cs

0101 approved these changes Jul 16, 2026

View reviewed changes

Evangelink merged commit 0a44195 into main Jul 16, 2026
68 checks passed

Evangelink deleted the dev/amauryleve/miniature-broccoli branch July 16, 2026 14:10

Evangelink mentioned this pull request Jul 16, 2026

Fix case-sensitivity probe corrupting directory path in MergeOutputFileHelper #10014

Merged

Uh oh!

Conversation

Evangelink commented Jul 9, 2026

Summary

1. Report merge engines (pure, invocation-agnostic — no I/O in the core)

2. Kind metadata flow (producer → IPC wire)

Tests

Not in this PR (future phases, per the RFC)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

2. `Kind` metadata flow (producer → IPC wire)