Skip to content

Prevent panes from shrinking below 2x2 cells #20564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhangxaochen wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Prevent panes from shrinking below 2x2 cells #20564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86c2e1e
Prevent panes from shrinking below 2x2 cells
zhangxaochen Aug 20, 2026
71aa8cc
Floor remaining viewport entry points at 2x2 cells
zhangxaochen Aug 24, 2026
50d9d76
Merge remote-tracking branch 'origin/main' into dev/min-pane-2x2
zhangxaochen Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/cascadia/TerminalApp/Pane.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2849,13 +2849,12 @@ void Pane::_AdvanceSnappedDimension(const bool widthOrHeight, LayoutSizeNode& si

// Method Description:
// - Get the absolute minimum size that this pane can be resized to and still
// have 1x1 character visible, in each of its children. If we're a leaf, we'll
// include the space needed for borders _within_ us.
// satisfy each child's MinimumSize. If we're a leaf, we'll include the
// space needed for borders _within_ us.
// Arguments:
// - <none>
// Return Value:
// - The minimum size that this pane can be resized to and still have a visible
// character.
// - The minimum size that this pane can be resized to and still fit its content.
Size Pane::_GetMinSize() const
{
if (_IsLeaf())
Expand Down
10 changes: 6 additions & 4 deletions src/cascadia/TerminalControl/TermControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2884,20 +2884,22 @@ namespace winrt::Microsoft::Terminal::Control::implementation

// Method Description:
// - Get the absolute minimum size that this control can be resized to and
// still have 1x1 character visible. This includes the space needed for
// still have 2x2 characters visible. This includes the space needed for
// the scrollbar and the padding.
// 2x2 is the VT theoretical minimum (DECSTBM / DECSLRM). A 1-cell
// viewport can hang TextBuffer::Reflow on a wide glyph (GH#19996).
// Arguments:
// - <none>
// Return Value:
// - The minimum size that this terminal control can be resized to and still
// have a visible character.
// have a usable character grid.
winrt::Windows::Foundation::Size TermControl::MinimumSize()
{
if (_initializedTerminal)
{
const auto fontSize = _core.FontSizeInDips();
auto width = fontSize.Width;
auto height = fontSize.Height;
auto width = fontSize.Width * 2;
auto height = fontSize.Height * 2;
// Reserve additional space if scrollbar is intended to be visible
if (_core.Settings().ScrollState() != ScrollbarState::Hidden)
{
Expand Down